Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update scalatest and discipline. #2806

Merged
merged 3 commits into from
Apr 25, 2019
Merged

update scalatest and discipline. #2806

merged 3 commits into from
Apr 25, 2019

Conversation

kailuowang
Copy link
Contributor

@kailuowang kailuowang commented Apr 24, 2019

This shall enable a 2.0-M1 release

@kailuowang
Copy link
Contributor Author

the property based test API in scalatest 3.1.0 has more breaking change than I thought. Closing this PR for now. will reopen once I fix them.

@kailuowang kailuowang closed this Apr 24, 2019
@kailuowang kailuowang reopened this Apr 24, 2019
@codecov-io
Copy link

codecov-io commented Apr 24, 2019

Codecov Report

Merging #2806 into master will decrease coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2806     +/-   ##
=========================================
- Coverage   94.15%   93.85%   -0.3%     
=========================================
  Files         368      368             
  Lines        6914     6936     +22     
  Branches      296      298      +2     
=========================================
  Hits         6510     6510             
- Misses        404      426     +22
Impacted Files Coverage Δ
testkit/src/main/scala/cats/tests/CatsSuite.scala 33.33% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16a38cb...e127497. Read the comment docs.

@kailuowang kailuowang added this to the 2.0.0-M1 milestone Apr 24, 2019
@LukaJCB
Copy link
Member

LukaJCB commented Apr 24, 2019

This looks good, though it worries me a bit that the ScalaTest Api has breaking changes in a minor version. I imagine this might affect people, using CatsSuite, no?

@kailuowang
Copy link
Contributor Author

@LukaJCB I think in most use cases, it shouldn't affect users using CatsSuite. But part of the point of having this M1 release is so that we can test the impact. I can try it with Cats-tagless and see what migration is needed.

@kailuowang kailuowang merged commit e9d5918 into master Apr 25, 2019
@kailuowang kailuowang deleted the kailuowang-patch-3 branch June 10, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants