-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update scalatest and discipline. #2806
Conversation
the property based test API in scalatest 3.1.0 has more breaking change than I thought. Closing this PR for now. will reopen once I fix them. |
9ef1495
to
e127497
Compare
Codecov Report
@@ Coverage Diff @@
## master #2806 +/- ##
=========================================
- Coverage 94.15% 93.85% -0.3%
=========================================
Files 368 368
Lines 6914 6936 +22
Branches 296 298 +2
=========================================
Hits 6510 6510
- Misses 404 426 +22
Continue to review full report at Codecov.
|
This looks good, though it worries me a bit that the ScalaTest Api has breaking changes in a minor version. I imagine this might affect people, using |
@LukaJCB I think in most use cases, it shouldn't affect users using CatsSuite. But part of the point of having this M1 release is so that we can test the impact. I can try it with Cats-tagless and see what migration is needed. |
This shall enable a 2.0-M1 release