Fix broken documentation links #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HI @liff, thanks for spotting this.
|
|
I can add fixes for the other broken links in this PR if that's OK? |
|
Of course, that would be great. |
Current coverage is 92.19% (diff: 100%)@@ master #1435 diff @@
==========================================
Files 242 242
Lines 3615 3615
Methods 3546 3546
Messages 0 0
Branches 69 69
==========================================
Hits 3333 3333
Misses 282 282
Partials 0 0
|
|
Here you go. There's one more broken link to Arrow.scala in the FAQ but I'm not sure where it should point to exactly. |
|
I think we lost We can probably fix that in another PR. |
|
👍 Thanks for fixing this! |
|
👍 |
DieBauer
added a commit
to DieBauer/cats
that referenced
this pull request
Dec 15, 2018
As stated by typelevel#1435 (comment) the `{{ site.sources }}` configuration item was lost. Already 6 occurrences exist in the docs that link directly to `https://github.com/typelevel/cats/blob/master`. In all documentation, this was the only place where `sources` was still used, so instead of adding a [custom yaml](https://47deg.github.io/sbt-microsites/docs/settings.html) and keep the tightly coupling with Jekyll, I've replaced this one instance with another hard-coded link to master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/tut/leads to a 404.