Fix broken link to Arrow.scala #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As stated by typelevel#1435 (comment) the `{{ site.sources }}` configuration item was lost. Already 6 occurrences exist in the docs that link directly to `https://github.com/typelevel/cats/blob/master`. In all documentation, this was the only place where `sources` was still used, so instead of adding a [custom yaml](https://47deg.github.io/sbt-microsites/docs/settings.html) and keep the tightly coupling with Jekyll, I've replaced this one instance with another hard-coded link to master.
Codecov Report
@@ Coverage Diff @@
## master #2668 +/- ##
=======================================
Coverage 95.12% 95.12%
=======================================
Files 364 364
Lines 6707 6707
Branches 301 285 -16
=======================================
Hits 6380 6380
Misses 327 327Continue to review full report at Codecov.
|
ceedubs
approved these changes
Dec 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated by #1435 (comment) the
{{ site.sources }}configuration item was lost.Already 6 occurrences exist in the docs that link directly to
https://github.com/typelevel/cats/blob/master.In all documentation, this was the only place where
sourceswas still used, so instead of adding a custom yaml and keep the tightly coupling with Jekyll, I've replaced this one instance with another hard-coded link to master.