Special Case parJoin 1 #2557
Merged
Special Case parJoin 1 #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasilmkd
approved these changes
Aug 13, 2021
bastewart
added a commit
to bastewart/fs2
that referenced
this pull request
Aug 27, 2021
This avoids the penalty of using the combinator if there is no concurrency. Analogous to typelevel#2557 which did the same for `parJoin`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this is an indentation change. White space should show that this is just
Basically meaning that when people select this, if the option selected is 1, then they don't pay any penalty for using this combinator.