-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add scala 3 release version flag #241
Conversation
Update scalafmt-core to 3.5.0
Add docs for sbt-(typelevel)-github-actions
Demonstrate how to add unidoc project filter in docs
rel #138 |
Thanks for the PR! :) A few quick notes:
Also, would you mind targeting your PR at |
Hmm, should we wrap |
That's a good question. I don't think we need our own |
Sure. In addition, are we going to use |
I think it's too hard to support this Scala 3 feature without relying on the sbt integration. So, we definitely need to rely on that I can't promise I'll merge this PR right away. I have to double-check when the planned release date for sbt v1.7.0 is and and decide whether sbt-typelevel v0.5.0 should wait for it or not. I don't currently feel a big rush to release sbt-typelevel v0.5.0 so that strategy may make sense. Meanwhile I am publishing some milestone prereleases of sbt-typelevel v0.5.0 so some people can use that with the sbt milestone prerelease, if they want. |
Okay. I'm not in a hurry too. |
@armanbilge Thanks for reviewing :) |
Thanks for your contribution! :) |
@i10416 if you're still interested in working on this one, I had an idea for how we can do this so it will be ready before sbt 1.7.0 is released, and also so we don't have to bump to sbt-typelevel 0.5.0. Basically, the idea is to use sbt "reflection", when you refer to a setting using a sbt-typelevel/sonatype/src/main/scala/org/typelevel/sbt/TypelevelUnidocPlugin.scala Line 38 in 66b313c
This technique will work even if somebody uses sbt-typelevel with sbt 1.6.x. It won't do anything, but at least it won't crash the build :) |
@armanbilge Oh! I didn't know that technique. |
No description provided.