support Scala 2.13.0-M5 (and drop M4) #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
that's odd, Travis-CI doesn't seem to be firing up. |
|
I get the following test failures (Travis doesn't run because the branch is not included in the Travis builds): |
|
@rickynils Looks like something that |
|
we also had some serialization trouble in the scala-xml repo. I've made this umbrella ticket so we don't forget to investigate: scala/scala-dev#562 |
|
@alexarchambault |
|
SerializabilitySpecification success if 🤔 |
Doing that in some of projects of mine too… Not sure why this is necessary (default class loader set up in tests, with some kind of filtering, confuses Java serialization?) |
|
Yup, that helps here, too: |
ashawley
reviewed
Oct 10, 2018
| - scala: 2.13.0-M4 | ||
| env: PLATFORM=js SBT_PARALLEL=true WORKERS=1 DEPLOY=true SCALAJS_VERSION=1.0.0-M3 | ||
| - scala: 2.13.0-M5 | ||
| env: PLATFORM=js SBT_PARALLEL=true WORKERS=1 DEPLOY=true SCALAJS_VERSION=0.6.25 |
There was a problem hiding this comment.
@SethTisue updated 0.6.25 in Travis, but missed the value inplugins.sbt, as well
There was a problem hiding this comment.
Actually, this is an exclude rule, so I'm wrong about the first part, but I think I'm right about the second part. It's important because I don't think Rickard uses Travis to deploy
rickynils
added a commit
that referenced
this pull request
Feb 25, 2019
rickynils
added a commit
that referenced
this pull request
Apr 4, 2019
(see #427 (comment)) (cherry picked from commit a3b07d2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
references #418