-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Scala.js and sbt versions (on 2.13 release branch) #435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'll try to figure out how to either update the code to fix this, or to disable the deprecation warning (for now). |
@non I tried disabling the deprecation warning (first for the js project, then generally), but did not succeed. It kept error out on the deprecations anyway. |
two examples of how it was done in other test frameworks (cc @sjrd)
it doesn't look super hard, but it's not trivial either, so in the interest of getting the M5 publishing done, I think for now it's fine to disable the deprecation warning. I'll look at that next. |
okay, I pushed a revised commit that disables I also downgraded sbt from 1.2.4 to 1.2.3 since I was hitting "different extra api hashes for no traits" (sbt/zinc#606) |
@SethTisue Thanks! I have now finally released the M5 build for the JS project too. |
sweet, thank you Rickard! |
@rickynils hopefully this will permit publishing 1.14.0 for Scala.js
on Scala 2.13.0-M5?