Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Scala.js and sbt versions (on 2.13 release branch) #435

Merged
merged 1 commit into from
Oct 17, 2018
Merged

update Scala.js and sbt versions (on 2.13 release branch) #435

merged 1 commit into from
Oct 17, 2018

Conversation

SethTisue
Copy link
Member

@rickynils hopefully this will permit publishing 1.14.0 for Scala.js
on Scala 2.13.0-M5?

@SethTisue SethTisue changed the title update Scala.js and sbt versions update Scala.js and sbt versions (on 2.13 release branch) Oct 10, 2018
Copy link
Contributor

@ashawley ashawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@non
Copy link
Contributor

non commented Oct 14, 2018

[error] /Users/erik/w/scalacheck/js/src/main/scala/org/scalacheck/Platform.scala:25:31: object TestUtils in package testinterface is deprecated (since 0.6.25): Use scala.scalajs.reflect.Reflect (JS-only) or https://github.com/portable-scala/portable-scala-reflect (portable) instead.
[error]     org.scalajs.testinterface.TestUtils.loadModule(name, loader)
[error]                               ^
[error] /Users/erik/w/scalacheck/js/src/main/scala/org/scalacheck/Platform.scala:28:31: object TestUtils in package testinterface is deprecated (since 0.6.25): Use scala.scalajs.reflect.Reflect (JS-only) or https://github.com/portable-scala/portable-scala-reflect (portable) instead.
[error]     org.scalajs.testinterface.TestUtils.newInstance(name, loader, paramTypes)(args)
[error]                               ^
[error] two errors found
[info] Done compiling.
[error] (js / Compile / compileIncremental) Compilation failed
[error] Total time: 32 s, completed Oct 14, 2018 4:53:54 PM

I'll try to figure out how to either update the code to fix this, or to disable the deprecation warning (for now).

@rickynils
Copy link
Contributor

@non I tried disabling the deprecation warning (first for the js project, then generally), but did not succeed. It kept error out on the deprecations anyway.

@SethTisue
Copy link
Member Author

SethTisue commented Oct 16, 2018

I'll try to figure out how to either update the code to fix this

two examples of how it was done in other test frameworks (cc @sjrd)

it doesn't look super hard, but it's not trivial either, so in the interest of getting the M5 publishing done, I think for now it's fine to disable the deprecation warning. I'll look at that next.

@SethTisue
Copy link
Member Author

okay, I pushed a revised commit that disables -Xfatal-warnings in the Scala.js build only

I also downgraded sbt from 1.2.4 to 1.2.3 since I was hitting "different extra api hashes for no traits" (sbt/zinc#606)

@rickynils rickynils merged commit 98ab589 into typelevel:1.14.0_sonatype Oct 17, 2018
@rickynils
Copy link
Contributor

@SethTisue Thanks! I have now finally released the M5 build for the JS project too.

@SethTisue
Copy link
Member Author

sweet, thank you Rickard!

@SethTisue SethTisue deleted the m5-followup branch October 17, 2018 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants