Separate Social lists to independent section

[Yuki2718]

Prerequisites

• I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
• This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
• This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
• I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
• The issue is not present after disabling uBO in the browser.
• I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

• uBO is the only extension.
• uBO uses default lists and settings.
• using a new, unmodified browser profile.

Description

Currently both AdGuard – Social Media and EasyList – Social Widgets are under Annoyances in Filter lists. I constantly see complaints that blocker hides sns buttons on Twitter, though most of them don't name which blocker they use and apparently many are either AdGuard (Social filter may be enabled depending on the installation process and products) and ABP (same). Those who check AdGuard – Annoyances and/or EasyList – Annoyances might not notice they include social lists.

A specific URL where the issue occurs.

chrome-extension://extensionID/dashboard.html#3p-filters.html

Steps to Reproduce

Obvious

Expected behavior

Social list should be in its own section

Actual behavior

Not

uBO version

1.56.0

Browser name and version

Chrome 122.0.6261.95

Operating System and version

Windows 10

[Yuki2718]

Some old complaints are in AdguardTeam/AdguardForWindows#3776. I stopped adding new tweets as it's not my intention to bother AdGuard devs for all these, but it keeps happening.

[gwarser]

Maybe the section should expand when enabled?

---

I think it does not block enough widgets and I have both enabled - "AdGuard – Social Media" is the only one enabled in AdGuard section because I mostly rely on EL lists.

[Yuki2718]

Maybe the section should expand when enabled?

You can't enable without expanding first. I don't think that fully prevents people to enable social lists unknowingly. AdGuard Social is completely independent from the rest of Annoyances in the first place, though Fanboy Annoyances includes Fanboy Social.

[gorhill]

You mean a new section at same level as Annoyances, or a sub section under Annoyances?

[Yuki2718]

You mean a new section at same level as Annoyances, or a sub section under Annoyances?

The former, with a label Social.

[gwarser]

You can't enable without expanding first.

Ah, it's not like POL lists section. POL lists are selected by default for me and collapsed. "Annoyances" section is collapsed by default and I thought "AdGuard – Annoyances" is also collapsed, but it's not.

I think it's pointless to change it, because people likely select everything from top to bottom without even reading what it says.

[gorhill]

As part of the changes I already removed the default expanded state of AG/EL Annoyances section, but I could make the Annoyances section itself expanded by default. Could be worth spinning off cookie notices-related lists in their own section as well since these are popular, and a lot of people have no idea uBO supports filtering out cookie notices.

[troysjanda]

Are the new sections supposed to be empty? the Cookie and Social I updated but both have no lists in them.

[gorhill]

They will be populated once your assets.dev.json updates.

[troysjanda]

Ok, that is done automatically? I'll check later.

…

On Sun, Mar 3, 2024, 4:46 PM Raymond Hill ***@***.***> wrote: They will be populated once your assets.dev.json updates. — Reply to this email directly, view it on GitHub <#3154 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AF336MKUNBOW6ZBVTYMEDYLYWO77LAVCNFSM6AAAAABED7N5M2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZVGQ3DINZWGE> . You are receiving this because you commented.Message ID: ***@***.***>

[gorhill]

It is set to update every ~13 days.

These sections should not be shown if they are empty, it's going to cause issues when releasing stable. I need to fix this.

[krystian3w]

IMO this break genesis of Fanboy Annoyances - these cut normaly socials + annoyances from one file (turning a blind eye to the list structure with !#include file).

---

Ok, that is done automatically? I'll check later.

importing config from a file will also work (instead waiting to 14 march 2024 or testing with fake date in machine).

[gorhill]

We are going to need spinning off a new assets.json for next stable release, maybe assets.2.json otherwise all versions before 1.57.0 will be broken by an assets.json with group names which are not built-in in those previous versions of uBO.

[Yuki2718]

Maybe related to this, but I got empty Filter lists which complains unsaved changes if I try to move to other tabs. I overrode with devbuild and no more complaints, but filters were still empty and I had to enable each list and settings one by one. 1.56 on Firefox.

[gorhill]

Stable release uses assets.json, and this one wasn't changed (yet). However, before I revisited how the changes to the categories should happen, I believe going from dev to stable could cause an issue because the then cached assets.json would be assets.dev.json, which contained values that would cause such breakage -- i.e. 1.56.0 isn't designed to deal with unexpected categories. But I revisited all this and going back and forth should work fine now with the new assets.dev.json -- though I didn't test this yet.