Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pyyaml as an optional extra #103

Closed
masklinn opened this issue Apr 26, 2022 · 1 comment
Closed

Add pyyaml as an optional extra #103

masklinn opened this issue Apr 26, 2022 · 1 comment

Comments

@masklinn
Copy link
Contributor

Currently, the dependency on pyyaml is a bit schyzophrenic:

  • it's in requirements.txt, which doesn't really explain what's what and is not used for normal installations
  • it's in the setup_requires of setup.py, which is for build-time dependencies

This means it will not work by default, the install will work then the import will fail when trying to load the yaml file.

Packaging thingies apparently have support for optional extras which can be opted in: https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#optional-dependencies
masklinn added a commit to masklinn/uap-python that referenced this issue Apr 27, 2022
@masklinn
Add comment clarifying use of yaml.load, remove requirements file
da65d85 
pyyaml hasn't been a required dependency for a very long time, it's
really not clear why ua-parser#70 reintroduced a requirements.txt for it,
unless there were points at which `install_requires` was not resolved
as a *dependency*, so pyyaml had to be separately installed for
`develop` to work?

See also: ua-parser#103
@masklinn masklinn mentioned this issue Apr 27, 2022
Merged
masklinn added a commit to masklinn/uap-python that referenced this issue Apr 27, 2022
@masklinn
Add comment clarifying use of yaml.load, remove requirements file
b3e923a 
pyyaml hasn't been a required dependency for a very long time, it's
really not clear why ua-parser#70 reintroduced a requirements.txt for it,
unless there were points at which `install_requires` was not resolved
as a *dependency*, so pyyaml had to be separately installed for
`develop` to work?

See also: ua-parser#103
masklinn added a commit to masklinn/uap-python that referenced this issue Apr 27, 2022
@masklinn
Add comment clarifying use of yaml.load, remove requirements file
57d08ce 
pyyaml hasn't been a required dependency for a very long time, it's
really not clear why ua-parser#70 reintroduced a requirements.txt for it,
unless there were points at which `install_requires` was not resolved
as a *dependency*, so pyyaml had to be separately installed for
`develop` to work?

See also: ua-parser#103
masklinn added a commit to masklinn/uap-python that referenced this issue Apr 27, 2022
@masklinn
Add comment clarifying use of yaml.load, remove requirements file
2d189b5 
pyyaml hasn't been a required dependency for a very long time, it's
really not clear why ua-parser#70 reintroduced a requirements.txt for it,
unless there were points at which `install_requires` was not resolved
as a *dependency*, so pyyaml had to be separately installed for
`develop` to work?

See also: ua-parser#103
masklinn added a commit to masklinn/uap-python that referenced this issue Apr 27, 2022
@masklinn
Add comment clarifying use of yaml.load, remove requirements file
bbc0011 
pyyaml hasn't been a required dependency for a very long time, it's
really not clear why ua-parser#70 reintroduced a requirements.txt for it,
unless there were points at which `install_requires` was not resolved
as a *dependency*, so pyyaml had to be separately installed for
`develop` to work?

See also: ua-parser#103
masklinn added a commit to masklinn/uap-python that referenced this issue Apr 27, 2022
@masklinn
Add comment clarifying use of yaml.load, remove requirements file
bb67054 
pyyaml hasn't been a required dependency for a very long time, it's
really not clear why ua-parser#70 reintroduced a requirements.txt for it,
unless there were points at which `install_requires` was not resolved
as a *dependency*, so pyyaml had to be separately installed for
`develop` to work?

See also: ua-parser#103
masklinn added a commit that referenced this issue Apr 30, 2022
@masklinn
Add comment clarifying use of yaml.load, remove requirements file
e27d50d 
pyyaml hasn't been a required dependency for a very long time, it's
really not clear why #70 reintroduced a requirements.txt for it,
unless there were points at which `install_requires` was not resolved
as a *dependency*, so pyyaml had to be separately installed for
`develop` to work?

See also: #103

Closes #106
@masklinn
Copy link
Contributor Author

masklinn commented May 5, 2023

Looks like that got merged as an incidental part of #148: https://github.com/ua-parser/uap-python/pull/148/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R12

So... cool.

@masklinn masklinn closed this as completed May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@masklinn