update uap-core submodule #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@admitad-github could you please look at the failing tests? |
|
Yes, will look at it today |
added 6 commits
April 23, 2019 12:50
|
@selwin ok, looks like all tests are passing now. Also, we added build matrix for Travis CI, so tests run in parallel now. |
|
Would be great to get this one through, really usefull @admitad-github |
|
I could definitely use this update. Thank you @admitad-github Thank you in advance @selwin |
|
awesome, can't wait for it to be merged |
|
@mattrobenolt any chance we can get this PR merged? Would be super helpful! |
|
Also would like to see this ship, but I think I need uap-core 0.6.8 (as I want to see support for parsing the new Edge Chromium user agent). It looks like uap-core@0.6.8 is not included in the latest version of this PR? |
|
@elsigh mind merging this one too? I'll send a PR to update to uap-core 0.6.9 after this is merged; figuring it doesn't make sense for me to redo this work. |
dgoldstein0
reviewed
Jul 27, 2019
| @@ -61,15 +61,15 @@ def Parse(self, user_agent_string): | |||
| if self.v1_replacement: | |||
| v1 = self.v1_replacement | |||
| elif match.lastindex and match.lastindex >= 2: | |||
| v1 = match.group(2) | |||
| v1 = match.group(2) or None | |||
There was a problem hiding this comment.
I am curious, is there any impact of this or None? seems like it would just cause v1 = None instead of v1 = '' - is that the intent?
There was a problem hiding this comment.
Yes, it was intended to match with the tests in uap-core, e.g. uap-core/tests/test_os.yaml, where some fields have None instead of empty string.
This was referenced Jul 30, 2019
|
or perhaps I could interest @tobie in merging this? |
|
I'm rolling with checks passing = ok |
|
awesome! |
masklinn
added a commit
to masklinn/uap-python
that referenced
this pull request
Apr 27, 2022
pyyaml hasn't been a required dependency for a very long time, it's really not clear why ua-parser#70 reintroduced a requirements.txt for it, unless there were points at which `install_requires` was not resolved as a *dependency*, so pyyaml had to be separately installed for `develop` to work?
masklinn
added a commit
to masklinn/uap-python
that referenced
this pull request
Apr 27, 2022
pyyaml hasn't been a required dependency for a very long time, it's really not clear why ua-parser#70 reintroduced a requirements.txt for it, unless there were points at which `install_requires` was not resolved as a *dependency*, so pyyaml had to be separately installed for `develop` to work? See also: ua-parser#103
masklinn
added a commit
to masklinn/uap-python
that referenced
this pull request
Apr 27, 2022
pyyaml hasn't been a required dependency for a very long time, it's really not clear why ua-parser#70 reintroduced a requirements.txt for it, unless there were points at which `install_requires` was not resolved as a *dependency*, so pyyaml had to be separately installed for `develop` to work? See also: ua-parser#103
masklinn
added a commit
to masklinn/uap-python
that referenced
this pull request
Apr 27, 2022
pyyaml hasn't been a required dependency for a very long time, it's really not clear why ua-parser#70 reintroduced a requirements.txt for it, unless there were points at which `install_requires` was not resolved as a *dependency*, so pyyaml had to be separately installed for `develop` to work? See also: ua-parser#103
masklinn
added a commit
to masklinn/uap-python
that referenced
this pull request
Apr 27, 2022
pyyaml hasn't been a required dependency for a very long time, it's really not clear why ua-parser#70 reintroduced a requirements.txt for it, unless there were points at which `install_requires` was not resolved as a *dependency*, so pyyaml had to be separately installed for `develop` to work? See also: ua-parser#103
masklinn
added a commit
to masklinn/uap-python
that referenced
this pull request
Apr 27, 2022
pyyaml hasn't been a required dependency for a very long time, it's really not clear why ua-parser#70 reintroduced a requirements.txt for it, unless there were points at which `install_requires` was not resolved as a *dependency*, so pyyaml had to be separately installed for `develop` to work? See also: ua-parser#103
masklinn
added a commit
to masklinn/uap-python
that referenced
this pull request
Apr 27, 2022
Also update internal version thingie to match. And remove 2.6 from the classifier tags, as it was dropped way back in 2019 (ua-parser#70, a9665f7)
masklinn
added a commit
to masklinn/uap-python
that referenced
this pull request
Apr 27, 2022
pyyaml hasn't been a required dependency for a very long time, it's really not clear why ua-parser#70 reintroduced a requirements.txt for it, unless there were points at which `install_requires` was not resolved as a *dependency*, so pyyaml had to be separately installed for `develop` to work? See also: ua-parser#103
masklinn
added a commit
to masklinn/uap-python
that referenced
this pull request
Apr 27, 2022
Also update internal version thingie to match. And remove 2.6 from the classifier tags, as it was dropped way back in 2019 (ua-parser#70, a9665f7)
masklinn
added a commit
that referenced
this pull request
Apr 30, 2022
pyyaml hasn't been a required dependency for a very long time, it's really not clear why #70 reintroduced a requirements.txt for it, unless there were points at which `install_requires` was not resolved as a *dependency*, so pyyaml had to be separately installed for `develop` to work? See also: #103 Closes #106
masklinn
added a commit
to masklinn/uap-python
that referenced
this pull request
Apr 30, 2022
Also update internal version thingie to match. And remove 2.6 from the classifier tags, as it was dropped way back in 2019 (ua-parser#70, a9665f7)
masklinn
added a commit
that referenced
this pull request
Apr 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated uap-core submodule have support for many new browsers.
Related issues #66, #68.