Update from uap-core 0.6.7 to 0.6.9 #74
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds off #70. The changes required to make tests work seem to mainly be in parts of the parser previously un-exercised by the test suite - the 3 test failures I found were two issues of empty string where None was required, and one where $2 and $3 were poking through in the OS detection for "MacOutlook/16.12.0.180401 (Intelx64 Mac OS X Version 10.12.6 (build 16G29))"
AssertionError: UA: MacOutlook/16.12.0.180401 (Intelx64 Mac OS X Version 10.12.6 (build 16G29))
expected<Mac OS X 10 12 6 None> != actual<Mac OS X 10 $2 $3 None>
so I repurposed the logic for dealing with those expressions in DeviceParser for OSParser as well.
after hacking this up I realized it's somewhat similar to PR #60; there's probably some merit in rebasing that PR and seeing if it caught anything I missed here, to help make future uap-core updates smoother; but that can be done as a followup