Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from uap-core 0.6.7 to 0.6.9 #74

Merged
merged 3 commits into from
Aug 1, 2019
Merged

Conversation

dgoldstein0
Copy link

Builds off #70. The changes required to make tests work seem to mainly be in parts of the parser previously un-exercised by the test suite - the 3 test failures I found were two issues of empty string where None was required, and one where $2 and $3 were poking through in the OS detection for "MacOutlook/16.12.0.180401 (Intelx64 Mac OS X Version 10.12.6 (build 16G29))"

AssertionError: UA: MacOutlook/16.12.0.180401 (Intelx64 Mac OS X Version 10.12.6 (build 16G29))
expected<Mac OS X 10 12 6 None> != actual<Mac OS X 10 $2 $3 None>
so I repurposed the logic for dealing with those expressions in DeviceParser for OSParser as well.

after hacking this up I realized it's somewhat similar to PR #60; there's probably some merit in rebasing that PR and seeing if it caught anything I missed here, to help make future uap-core updates smoother; but that can be done as a followup

@dgoldstein0
Copy link
Author

@elsigh any chance I could convince you to merge this and then do a 0.9.0 release to pypi?

@elsigh elsigh merged commit a9727e4 into ua-parser:master Aug 1, 2019
@elsigh
Copy link
Contributor

elsigh commented Aug 1, 2019

@dgoldstein0 - I did the merge, but I don't believe I can do a release to pypi

@dgoldstein0
Copy link
Author

thanks. Any idea who has the ability to push a new version to pypi?

@elsigh
Copy link
Contributor

elsigh commented Aug 3, 2019 via email

@dgoldstein0
Copy link
Author

According to https://pypi.org/project/ua-parser/#data the maintainers are Matt Robenolt and Selwin. My guess is that they are probably the only people who could publish a new version.

@mattrobenolt
Copy link
Member

Hi.

@dgoldstein0
Copy link
Author

Hello Matt! Mind publishing a new version to pypi? Probably should be 0.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants