Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use golangci-lint for linting #108

Merged
merged 1 commit into from
Oct 21, 2023
Merged

ci: Use golangci-lint for linting #108

merged 1 commit into from
Oct 21, 2023

Conversation

abhinav
Copy link
Collaborator

@abhinav abhinav commented Oct 21, 2023

Instead of hand-managing and running linters, use golangci-lint.
This simplifies the Makefile and allows lint to run in parallel
with the build/test job.

Along with the golangci-lint defaults,
enable a couple other linters we generally agree with.
See also uber-go/zap#1323 and uber-go/sally#121 for similar changes.

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #108 (586e0e3) into master (03cb6e6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #108   +/-   ##
=======================================
  Coverage   96.58%   96.58%           
=======================================
  Files           5        5           
  Lines         234      234           
=======================================
  Hits          226      226           
  Misses          5        5           
  Partials        3        3           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

go.mod Outdated Show resolved Hide resolved
Instead of hand-managing and running linters, use golangci-lint.
This simplifies the Makefile and allows lint to run in parallel
with the build/test job.

Along with the golangci-lint defaults,
enable a couple other linters we generally agree with.
See also uber-go/zap#1323 and uber-go/sally#121 for similar changes.
@sywhang sywhang merged commit f995fdb into uber-go:master Oct 21, 2023
6 checks passed
@abhinav abhinav deleted the golangci-lint branch October 21, 2023 20:41
abhinav added a commit that referenced this pull request Oct 23, 2023
The CI job was renamed to ci.yml in #108
but the README.md was not updated.

Fix the badge URL in the README.
abhinav added a commit that referenced this pull request Oct 23, 2023
The CI job was renamed to ci.yml in #108
but the README.md was not updated.

Fix the badge URL in the README.
@mway mway mentioned this pull request Oct 24, 2023
mway added a commit that referenced this pull request Oct 24, 2023
### Fixed
- Built-in ignores now match function names more accurately.
  They will no longer ignore stacks because of file names
  that look similar to function names. (#112)
### Added
- Add an `IgnoreAnyFunction` option to ignore stack traces
  that have the provided function anywhere in the stack. (#113)
- Ignore `testing.runFuzzing` and `testing.runFuzzTests` alongside
  other already-ignored test functions (`testing.RunTests`, etc). (#105)

### Changed
- Miscellaneous CI-related fixes. (#103, #108, #114)

---------

Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants