ci: Use golangci-lint for linting #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
=======================================
Coverage 96.58% 96.58%
=======================================
Files 5 5
Lines 234 234
=======================================
Hits 226 226
Misses 5 5
Partials 3 3 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sywhang
approved these changes
Oct 21, 2023
rabbbit
reviewed
Oct 21, 2023
Instead of hand-managing and running linters, use golangci-lint. This simplifies the Makefile and allows lint to run in parallel with the build/test job. Along with the golangci-lint defaults, enable a couple other linters we generally agree with. See also uber-go/zap#1323 and uber-go/sally#121 for similar changes.
abhinav
added a commit
that referenced
this pull request
Oct 23, 2023
The CI job was renamed to ci.yml in #108 but the README.md was not updated. Fix the badge URL in the README.
abhinav
added a commit
that referenced
this pull request
Oct 23, 2023
The CI job was renamed to ci.yml in #108 but the README.md was not updated. Fix the badge URL in the README.
Merged
mway
added a commit
that referenced
this pull request
Oct 24, 2023
### Fixed - Built-in ignores now match function names more accurately. They will no longer ignore stacks because of file names that look similar to function names. (#112) ### Added - Add an `IgnoreAnyFunction` option to ignore stack traces that have the provided function anywhere in the stack. (#113) - Ignore `testing.runFuzzing` and `testing.runFuzzTests` alongside other already-ignored test functions (`testing.RunTests`, etc). (#105) ### Changed - Miscellaneous CI-related fixes. (#103, #108, #114) --------- Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hand-managing and running linters, use golangci-lint.
This simplifies the Makefile and allows lint to run in parallel
with the build/test job.
Along with the golangci-lint defaults,
enable a couple other linters we generally agree with.
See also uber-go/zap#1323 and uber-go/sally#121 for similar changes.