Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options: Add IgnoreAnyFunction #113

Merged
merged 2 commits into from
Oct 23, 2023
Merged

options: Add IgnoreAnyFunction #113

merged 2 commits into from
Oct 23, 2023

Conversation

abhinav
Copy link
Collaborator

@abhinav abhinav commented Oct 21, 2023

Adds a new IgnoreAnyFunction option to ignore stacks
that have the provided function anywhere in the stack,
not just the top.

To test this better, the helper blockedG.run function
was split into two.

Supersedes #80
Depends on #111

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #113 (fe4c855) into master (91de685) will increase coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   98.50%   98.52%   +0.01%     
==========================================
  Files           6        6              
  Lines         334      338       +4     
==========================================
+ Hits          329      333       +4     
  Misses          4        4              
  Partials        1        1              
Files Coverage Δ
options.go 100.00% <100.00%> (ø)
tracestack_new.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@abhinav abhinav force-pushed the parse-stack branch 2 times, most recently from f46c0cd to 7bdc274 Compare October 22, 2023 18:15
@abhinav abhinav force-pushed the ignore-any branch 2 times, most recently from f82c00b to bff05ad Compare October 22, 2023 23:24
Base automatically changed from parse-stack to master October 23, 2023 04:16
Adds a new IgnoreAnyFunction option to ignore stacks
that have the provided function anywhere in the stack,
not just the top.

To test this better, the helper blockedG.run function
was split into two.

Supersedes #80
@abhinav abhinav merged commit 7b4998f into master Oct 23, 2023
7 checks passed
@abhinav abhinav deleted the ignore-any branch October 23, 2023 14:52
@mway mway mentioned this pull request Oct 24, 2023
mway added a commit that referenced this pull request Oct 24, 2023
### Fixed
- Built-in ignores now match function names more accurately.
  They will no longer ignore stacks because of file names
  that look similar to function names. (#112)
### Added
- Add an `IgnoreAnyFunction` option to ignore stack traces
  that have the provided function anywhere in the stack. (#113)
- Ignore `testing.runFuzzing` and `testing.runFuzzTests` alongside
  other already-ignored test functions (`testing.RunTests`, etc). (#105)

### Changed
- Miscellaneous CI-related fixes. (#103, #108, #114)

---------

Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants