Bug fixes for compactCells #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfellis
approved these changes
Jan 17, 2022
nrabinowitz
approved these changes
Jan 22, 2022
| // algorithm below may encounter undefined behavior | ||
| // because it expects to have set the reserved bits | ||
| // itself. | ||
| if (H3_GET_RESERVED_BITS(currIndex) != 0) { |
There was a problem hiding this comment.
Not required, but I wonder if it would make sense to do this kind of validity check first, and fail faster? We could do this without allocating any memory we need to free, and it wouldn't change the complexity
There was a problem hiding this comment.
I'd leave that to a separate PR with benchmarks to say
Co-authored-by: Nick Rabinowitz <public@nickrabinowitz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based upon #553. This updates the fuzzer, and applies some cases found via fuzzing to the test suite.