-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade template structure #93
Conversation
@obeys, this task has been idle for a while. Please provide an update. |
waiting on @zugdev 🧛 |
this is ok, not considering style. if I were to consider then at least the 404 page should look decent at least because it can be shared between implementations. @0x4007 we should probably settle on a header style for our UIs |
Unresolved imports (1)
|
@0x4007 jest was failing because it was trying to parse I've converted both 404 and home page into components, let me know if there's anything else that I need to do. |
I think linking a shared 404 page would be much more maintainable across all our UIs. For example dao.ubq.fi/404 |
Where would i be able to find the SRC for that page by any chance? I tried searching the |
Ok I have managed to somewhat recreate that 404 page, I feel like it looks a lot better now but lmk @0x4007 ! |
No use just a link to it |
You want me to redirect to Or I can display it with an iframe if that's what you mean |
Redirect is fine |
changed 404 page logic to redirect and removed the component + styles. |
is this good to be merged? @rndquu |
Resolves #92
Changes:
Added
src
which will include:two components
four controllers
a router
and
on-load.ts
for global state initializationstatic
directory will now only include different html pagesQA:
How to QA and setup: