Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade template structure #93

Merged
merged 8 commits into from
Dec 19, 2024
Merged

Conversation

obeys
Copy link
Contributor

@obeys obeys commented Dec 11, 2024

Resolves #92

Changes:

Added src which will include:

  • two components

  • four controllers

  • a router

  • and on-load.ts for global state initialization

static directory will now only include different html pages

  • index (which will serve as a layout)
  • home
  • 404
  • and two different example pages

QA:

How to QA and setup:

  • deploy to any web host

@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Dec 11, 2024

@rndquu rndquu requested a review from zugdev December 12, 2024 13:04
Copy link

ubiquity-os bot commented Dec 16, 2024

@obeys, this task has been idle for a while. Please provide an update.

@ubiquity-os ubiquity-os bot marked this pull request as draft December 16, 2024 05:24
@obeys
Copy link
Contributor Author

obeys commented Dec 16, 2024

waiting on @zugdev 🧛

@zugdev
Copy link
Contributor

zugdev commented Dec 16, 2024

this is ok, not considering style. if I were to consider then at least the 404 page should look decent at least because it can be shared between implementations. @0x4007 we should probably settle on a header style for our UIs

@zugdev zugdev marked this pull request as ready for review December 16, 2024 18:05
src/controllers/404.ts Outdated Show resolved Hide resolved
src/controllers/home.ts Outdated Show resolved Hide resolved
Copy link
Contributor

Unresolved imports (1)

Filename unresolved
src/on-load.ts ./types

@obeys
Copy link
Contributor Author

obeys commented Dec 16, 2024

@0x4007 jest was failing because it was trying to parse html files as jsx which isn't supported. I tried adding a babel config file which is what it was suggesting me to do but jest was still failing.

I've converted both 404 and home page into components, let me know if there's anything else that I need to do.

@0x4007
Copy link
Member

0x4007 commented Dec 17, 2024

I think linking a shared 404 page would be much more maintainable across all our UIs. For example dao.ubq.fi/404

@obeys
Copy link
Contributor Author

obeys commented Dec 17, 2024

I think linking a shared 404 page would be much more maintainable across all our UIs. For example dao.ubq.fi/404

Where would i be able to find the SRC for that page by any chance? I tried searching the ubiquity org but was unable to find any dao.ubq.fi repos

@obeys
Copy link
Contributor Author

obeys commented Dec 17, 2024

Ok I have managed to somewhat recreate that 404 page, I feel like it looks a lot better now but lmk @0x4007 !

@0x4007
Copy link
Member

0x4007 commented Dec 18, 2024

No use just a link to it

@obeys
Copy link
Contributor Author

obeys commented Dec 18, 2024

No use just a link to it

You want me to redirect to https://dao.ubq.fi/404 incase of a 404?

Or I can display it with an iframe if that's what you mean

@0x4007
Copy link
Member

0x4007 commented Dec 18, 2024

Redirect is fine

@obeys
Copy link
Contributor Author

obeys commented Dec 18, 2024

changed 404 page logic to redirect and removed the component + styles.

@obeys
Copy link
Contributor Author

obeys commented Dec 18, 2024

is this good to be merged? @rndquu

@rndquu rndquu self-requested a review December 19, 2024 14:18
@rndquu rndquu merged commit ca42c18 into ubiquity:development Dec 19, 2024
4 checks passed
@ubiquity-os ubiquity-os bot mentioned this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better template structure
5 participants