Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend basic_cli example with more cmd line arguments #71

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

andrei-ng
Copy link
Contributor

As discussed some time ago in #61, this PR adds more CLI args via clap to the basic example.

While the example of using the uBlox library itself is indeed basic, the clap argument handling has become a bit more complex.

@gwbres let me know what you think.

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
@gwbres
Copy link
Collaborator

gwbres commented Nov 10, 2023

looks great ! I think its awesome especially for people connecting to a ublox for the first time.
The only thing, I think ublox-cli is a much more "intuitive" name than the proposed one right now

@andrei-ng
Copy link
Contributor Author

OK. Will change it to ublox-cli, I agree.

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
@gwbres gwbres merged commit ef9c16f into ublox-rs:master Nov 10, 2023
6 checks passed
@andrei-ng
Copy link
Contributor Author

@gwbres , change the name and also enabled NavPVT on all ports. Thank you!

@andrei-ng andrei-ng deleted the ang/extend-basic-example branch November 10, 2023 15:33
aholtzma pushed a commit to appliedmind/ublox that referenced this pull request Nov 16, 2023
parser: move test into "mod tests"

CI: make sure that we test with all features "on"

fix parsing of MonVer packet plus regressioni test for that

Fix compilation on `no_std`.

Merge pull request ublox-rs#49 from reitermarkus/no-std

Fix compilation on `no_std`.
Merge branch 'master' into fix-mon-ver-parsing
Merge pull request ublox-rs#47 from Dushistov/fix-mon-ver-parsing

Fix mon ver parsing
Fix enum casing. (ublox-rs#50)

Update minimum required version to 1.65 (ublox-rs#58)

* Update minimum required version to 1.65

---------

Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
add support for UBX-SEC-UNIQID (ublox-rs#48)

Co-authored-by: gwbres <guillaume.bressaix@gmail.com>
introduce cargo fmt and execute it a first time (ublox-rs#59)

Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
Introduce clippy fixes, auto derive default (ublox-rs#60)

* apply clippy fixes, derive Default enum
* Clippy on CI level
* Swap to match statements
* Derive eq
bump rustc and dependencies to newer versions (ublox-rs#61)

* bumps dependencies for ublox library

- bumps all dependencies to more recent versions
- lints Cargo.toml files
- updates ublox_cli example to work with new `clap` and `serialport` APIs
- tested ublox_cli example on M8L device
- update CI and README with rustc version
- fix urls in badges

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>

* move cli example to examples

- exclude the examples from the top level workspace
- allow to build examples independently and with newer MVRC
- update CI to build examples separately

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>

* fix clippy & fmt errors

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>

---------

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
add ci workflow badge to the readme (ublox-rs#62)

Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
add hnr messages (ublox-rs#63)

* rename UBX-NAV-PVT message as per uBlox protocol description

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>

* refactor: add more NAV-PVT mapping functions

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>

* add HNR-ATT and HNR-INS messages

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>

---------

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
use uniform `itow` naming across packets (ublox-rs#64)

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
release v0.4.3 (ublox-rs#65)

Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
clippy changes (ublox-rs#67)

Improve support for embedded targets (ublox-rs#69)

* ci: test building on embedded targets
* Set resolver=2 in the workspace
* ci: test with feature serde but no alloc
* derive: Manually impl Serialize for PacketSerializer
to avoid the serde feature requiring alloc
bump ublox_derive to v0.1.0 (ublox-rs#70)

* bump ublox_derive to v0.1.0
* ublox: use local referencing (latest)
---------

Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
extend basic_cli example with more cmd line arguments (ublox-rs#71)

* refactor: workflow file

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>

* refactor: small update in doc & README

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>

* expand ublox-cli example with more cli-args

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>

---------

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
Add NAV-SIG and CFG-GNSS messages.

Merge remote-tracking branch 'upstream/master' into nav-sig

Fix PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants