Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use uniform itow naming across packets #64

Merged
merged 1 commit into from
Sep 15, 2023
Merged

use uniform itow naming across packets #64

merged 1 commit into from
Sep 15, 2023

Conversation

andrei-ng
Copy link
Contributor

No description provided.

@andrei-ng
use uniform itow naming across packets
5a3caff 
Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
@andrei-ng
Copy link
Contributor Author

@gwbres would you have time to approve this ?

@gwbres
Copy link
Collaborator

gwbres commented Sep 15, 2023

@gwbres would you have time to approve this ?

Hello, yes I do.
what do you think about renaming to tow ?

@andrei-ng
Copy link
Contributor Author

@gwbres would you have time to approve this ?

Hello, yes I do. what do you think about renaming to tow ?

IMO it should stay "itow" as in the manual since the meaning apparently (I had to search for it myself) is "Integer Time Of Week" which is meant to differentiate it from "TOW" that has typical units seconds.

What is your point of view?

@gwbres
Copy link
Collaborator

gwbres commented Sep 15, 2023

@gwbres would you have time to approve this ?

Hello, yes I do. what do you think about renaming to tow ?

IMO it should stay "itow" as in the manual since the meaning apparently (I had to search for it myself) is "Integer Time Of Week" which is meant to differentiate it from "TOW" that has typical units seconds.

What is your point of view?

Oh I did'nt know it was the official name in the UBX definitions. Let's keep it that way then

gwbres
gwbres approved these changes Sep 15, 2023
View reviewed changes
ublox/src/ubx_packets/packets.rs Show resolved Hide resolved
@gwbres gwbres merged commit 492f320 into ublox-rs:master Sep 15, 2023
4 checks passed
@andrei-ng
Copy link
Contributor Author

@gwbres would you have time to approve this ?

Hello, yes I do. what do you think about renaming to tow ?

IMO it should stay "itow" as in the manual since the meaning apparently (I had to search for it myself) is "Integer Time Of Week" which is meant to differentiate it from "TOW" that has typical units seconds.
What is your point of view?

Oh I did'nt know it was the official name in the UBX definitions. Let's keep it that way then

I didn't know why it was named iTow specifically either before you asked. So good you asked, we both learned something today :) .

For completeness, from the uBLOX F9P manual :

The original designers of GPS chose to express time/date as an integer week number (starting
with the first full week in January 1980) and a time of week (often abbreviated to TOW)
expressed in seconds. Manipulating time/date in this form is far easier for digital systems than
the more conventional year/month/day, hour/minute/second representation. Consequently,
most GNSS receivers use this representation internally, only converting to a more conventional
form at external interfaces. The iTOW field is the most obvious externally visible consequence
of this internal representation.

https://content.u-blox.com/sites/default/files/ZED-F9P_IntegrationManual_UBX-18010802.pdf

@andrei-ng andrei-ng deleted the ang/uniform-itow-naming branch November 10, 2023 15:33
aholtzma pushed a commit to appliedmind/ublox that referenced this pull request Nov 16, 2023
@aholtzma-am
fix formating (cargo fmt)
3a847ee 
parser: move test into "mod tests"

CI: make sure that we test with all features "on"

fix parsing of MonVer packet plus regressioni test for that

Fix compilation on `no_std`.

Merge pull request ublox-rs#49 from reitermarkus/no-std

Fix compilation on `no_std`.
Merge branch 'master' into fix-mon-ver-parsing
Merge pull request ublox-rs#47 from Dushistov/fix-mon-ver-parsing

Fix mon ver parsing
Fix enum casing. (ublox-rs#50)

Update minimum required version to 1.65 (ublox-rs#58)

* Update minimum required version to 1.65

---------

Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
add support for UBX-SEC-UNIQID (ublox-rs#48)

Co-authored-by: gwbres <guillaume.bressaix@gmail.com>
introduce cargo fmt and execute it a first time (ublox-rs#59)

Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
Introduce clippy fixes, auto derive default (ublox-rs#60)

* apply clippy fixes, derive Default enum
* Clippy on CI level
* Swap to match statements
* Derive eq
bump rustc and dependencies to newer versions (ublox-rs#61)

* bumps dependencies for ublox library

- bumps all dependencies to more recent versions
- lints Cargo.toml files
- updates ublox_cli example to work with new `clap` and `serialport` APIs
- tested ublox_cli example on M8L device
- update CI and README with rustc version
- fix urls in badges

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>

* move cli example to examples

- exclude the examples from the top level workspace
- allow to build examples independently and with newer MVRC
- update CI to build examples separately

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>

* fix clippy & fmt errors

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>

---------

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
add ci workflow badge to the readme (ublox-rs#62)

Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
add hnr messages (ublox-rs#63)

* rename UBX-NAV-PVT message as per uBlox protocol description

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>

* refactor: add more NAV-PVT mapping functions

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>

* add HNR-ATT and HNR-INS messages

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>

---------

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
use uniform `itow` naming across packets (ublox-rs#64)

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
release v0.4.3 (ublox-rs#65)

Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
clippy changes (ublox-rs#67)

Improve support for embedded targets (ublox-rs#69)

* ci: test building on embedded targets
* Set resolver=2 in the workspace
* ci: test with feature serde but no alloc
* derive: Manually impl Serialize for PacketSerializer
to avoid the serde feature requiring alloc
bump ublox_derive to v0.1.0 (ublox-rs#70)

* bump ublox_derive to v0.1.0
* ublox: use local referencing (latest)
---------

Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
extend basic_cli example with more cmd line arguments (ublox-rs#71)

* refactor: workflow file

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>

* refactor: small update in doc & README

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>

* expand ublox-cli example with more cli-args

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>

---------

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
Add NAV-SIG and CFG-GNSS messages.

Merge remote-tracking branch 'upstream/master' into nav-sig

Fix PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwbres gwbres gwbres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrei-ng @gwbres