Fix race conditions in starting adb #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we don't return the start-server exec promise, clients would run more adb commands before the server was up. This would cause "Connection Refused" to be returned to the second adb command, and everyone was confused. Actually returning the exec allows downstreams to wait on the server starting. Ref: ubports/ubports-installer#1847
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 1653 1651 -2
=========================================
- Hits 1653 1651 -2
Continue to review full report at Codecov.
|
Using 'npm install' causes npm to install the newest possible dependencies based on package.json. 'npm ci' uses package-lock.json instead. This ensures that releases are reproducible and so are test failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't return the start-server exec promise, clients would run more adb commands before the server was up. This would cause "Connection Refused" to be returned to the second adb command, and everyone was confused.
Actually returning the exec allows downstreams to wait on the server starting.
Ref: ubports/ubports-installer#1847