-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Internet connection lost" appears immediately when starting installer on macOS or Windows #1847
Comments
dev tools only show requests made from the ui process, not from the main process (where all the magic happens nowadays). Requests made at startup include fetching the list of supported devices, as well as confirming the running version of the installer is the latest version. |
More investigation today reveals that the issue is the Heimdall binary exiting without any output on Windows and macOS. This is even happening with the newest version of Heimdall available from their website.
This may be the exit code |
There are two problems here:
|
The issue with Heimdall is now filed as https://gitlab.com/ubports/installer/android-tools-bin/-/issues/1. I still don't think it should cause an "Internet connection lost" error. |
The error on macOS is actually different:
Interesting enough, the error doesn't occur on the ADB's log file sheds almost no light on the situation:
The same error occurs after a reboot, so I don't think it's a problem of adb already running. |
Prior to this change, it was possible for errors initializing or waiting on plugins to go undetected. Errors in wait() would bubble up to the "no-network" error, which has been even more confusing for users. Related, but does not fix: #1847
Since we don't return the start-server exec promise, clients would run more adb commands before the server was up. This would cause "Connection Refused" to be returned to the second adb command, and everyone was confused. Actually returning the exec allows downstreams to wait on the server starting. Ref: ubports/ubports-installer#1847
Prior to this change, it was possible for errors initializing or waiting on plugins to go undetected. Errors in wait() would bubble up to the "no-network" error, which has been even more confusing for users. Related, but does not fix: #1847
You can work around this issue by downloading an older version of the UBports Installer, such as 0.8.6. After this issue is closed, there is no reason to download an older version of the UBports Installer any more.
When starting the installer 0.8.7 or the prerelease 0.8.8, the "internet connection lost" message appears immediately. It does not appear that it's actually made any network requests at this point, or it's made requests that the Chrome devtools can't see.
The only log is:
I do feel rather welcomed, at least!
The text was updated successfully, but these errors were encountered: