Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fastboot:assert_var and adb:assert_prop actions for #2505 #2529

Merged
merged 3 commits into from
Mar 24, 2022

Conversation

NeoTheThird
Copy link
Member

@NeoTheThird NeoTheThird commented Mar 23, 2022

Resolves #2505. Specified in ubports/installer-configs#178.

Example:

        - adb:assert_prop:
            prop: "ro.ubuntu.recovery"
            value: "true"
        - fastboot:assert_var:
            variable: "ro.ubuntu.recovery"
            value: "true"
        - adb:assert_prop:
            prop: "ro.ubuntu.recovery"
            regex:
              pattern: "true"
              flags: "i"
        - fastboot:assert_var:
            variable: "ro.ubuntu.recovery"
            regex:
              pattern: "true"
              flags: "i"
        - systemimage:install:
              verify_recovery: true

```yml
      - actions:
          - adb:assert_prop:
              prop: "ro.ubuntu.recovery"
              value: "true"
      - actions:
          - fastboot:assert_var:
              variable: "ro.ubuntu.recovery"
              value: "true"
```
@NeoTheThird NeoTheThird linked an issue Mar 23, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #2529 (c01c54a) into master (315d534) will increase coverage by 0.28%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2529      +/-   ##
==========================================
+ Coverage   75.42%   75.70%   +0.28%     
==========================================
  Files          29       29              
  Lines         948      959      +11     
==========================================
+ Hits          715      726      +11     
  Misses        233      233              
Impacted Files Coverage Δ
src/core/plugins/systemimage/plugin.js 100.00% <ø> (ø)
src/core/plugins/adb/plugin.js 80.26% <100.00%> (+1.38%) ⬆️
src/core/plugins/fastboot/plugin.js 43.43% <100.00%> (+3.00%) ⬆️
src/core/plugins/systemimage/api.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 315d534...c01c54a. Read the comment docs.

Tweak adb:assert_prop and fastboot:assert_var to support regex as specified in ubports/installer-configs#178

Example:

```yml
        - adb:assert_prop:
            prop: "ro.ubuntu.recovery"
            value: "true"
        - adb:assert_prop:
            prop: "ro.ubuntu.recovery"
            regex:
              pattern: "true"
              flags: "i"
        - fastboot:assert_var:
            variable: "ro.ubuntu.recovery"
            value: "true"
        - fastboot:assert_var:
            variable: "ro.ubuntu.recovery"
            regex:
              pattern: "true"
              flags: "i"
```
Option as specified in ubports/installer-configs#178

Example:

```yml
- systemimage:install:
    verify_recovery: true
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure recovery supports installing Ubuntu Touch
1 participant