fix: Sets some best-effort timeouts #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosNihelton
force-pushed
the
wsl-exe-timeouts
branch
from
838da8e
to
b9baffc
Compare
Those functions used the background context. When wslservice.exe hangs/crashes, wsl.exe commands might hang for very long. We're setting some generous timeouts to couple with a variety of hardware. In the happy paths, 1/100th to 1/10th of those timeouts should be enough.
CarlosNihelton
force-pushed
the
wsl-exe-timeouts
branch
from
b9baffc
to
e2c23e0
Compare
didrocks
reviewed
Jun 19, 2024
didrocks
reviewed
Jun 19, 2024
There was a problem hiding this comment.
Just one comment to double ensure we want to commit to that API. Otherwise, on the timeout itself, this looks good to me. I am a little bit afraid of the à second timeout for list and so on on slower machine and I would really relax them still a bit, as they are just timeouts (like 5 seconds is the minimum of something else is happening on the machine)
Minimum of 5s, with 10s for Shutdown which seems to do more work.
Until we have a definite reason to expose it.
didrocks
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those functions used the background context.
When wslservice.exe hangs/crashes, wsl.exe commands might hang for very long, so would those functions.
We're setting some generous timeouts to couple with a variety of hardware. In the happy paths, 1/100th to 1/10th of those timeouts should be enough.
UDENG-3129