Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sets some best-effort timeouts #115

Merged
merged 3 commits into from
Jun 21, 2024
Merged

fix: Sets some best-effort timeouts #115

merged 3 commits into from
Jun 21, 2024

Commits on Jun 18, 2024

  1. Sets some best-effort timeouts

    Those functions used the background context.
    When wslservice.exe hangs/crashes, wsl.exe commands might hang for very long.
    We're setting some generous timeouts to couple with a variety of hardware.
    In the happy paths, 1/100th to 1/10th of those timeouts should be enough.
    CarlosNihelton committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    e2c23e0 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. More relaxed timeouts

    Minimum of 5s, with 10s for Shutdown which
    seems to do more work.
    CarlosNihelton committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    62215fb View commit details
    Browse the repository at this point in the history
  2. Make the error value private

    Until we have a definite reason to expose it.
    CarlosNihelton committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    0edba5b View commit details
    Browse the repository at this point in the history