fix: use AuthURLParam to set client id and secret #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some providers, like google, request a client secret for the device authentication. Make it optional, so that the admin can set it if required in the generic broker.
workaround to deal with #golang/oauth2/320
3v1n0
approved these changes
Nov 11, 2024
Comment on lines
+323
to
+331
|
|
||
| var opt oauth2.AuthCodeOption | ||
|
|
||
| if secret := session.authCfg.oauth.ClientSecret; secret != "" { | ||
| opt = oauth2.SetAuthURLParam("client_secret", secret) | ||
| } | ||
|
|
||
| response, err := session.authCfg.oauth.DeviceAuth(ctx, opt) | ||
|
|
There was a problem hiding this comment.
Just a nit:
Suggested change
| var opt oauth2.AuthCodeOption | |
| if secret := session.authCfg.oauth.ClientSecret; secret != "" { | |
| opt = oauth2.SetAuthURLParam("client_secret", secret) | |
| } | |
| response, err := session.authCfg.oauth.DeviceAuth(ctx, opt) | |
| var authOpt oauth2.AuthCodeOption | |
| if secret := session.authCfg.oauth.ClientSecret; secret != "" { | |
| authOpt = oauth2.SetAuthURLParam("client_secret", secret) | |
| } | |
| response, err := session.authCfg.oauth.DeviceAuth(ctx, authOpt) |
3v1n0
requested changes
Nov 11, 2024
|
I would also appreciate an actual link to the issue instead of #golang/oauth2/320. Thanks! |
didrocks
force-pushed
the
optional_client_secret
branch
from
ce2aced to
9415c6a
Compare
Yeah, I wanted to mention that too for us old school |
|
Now that #178 is merged, do you mind rebasing on it and target the main branch directly? Also, a small comment explaining which providers needs this and the details would be great too! Thanks :) |
shipperizer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workaround to deal with golang/oauth2#320