fix: use AuthURLParam to set client id and secret #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shipperizer
force-pushed
the
cc/secret
branch
2 times, most recently
from
55eccc5 to
a5a3be5
Compare
|
Thanks for adding the comments + fix the slice. I will give it a try on msentraid and enabled the tests in CI. |
didrocks
requested changes
Nov 13, 2024
|
Tests are passing on MSEntraID. |
shipperizer
force-pushed
the
cc/secret
branch
2 times, most recently
from
a69ef9d to
96ed371
Compare
Co-authored-by: 3v1n0 <mail@3v1n0.net> workaround to deal with golang/oauth2#320 tldr is that IDP servers tend to not be fully compliant with how client credentials are passed and have bespoke arrangements so anything goes this enforces the standard implementation from the RFC and has it working for any RFC compliant OIDC server full info here golang/oauth2#320
shipperizer
force-pushed
the
cc/secret
branch
from
96ed371 to
6df5401
Compare
didrocks
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workaround to deal with golang/oauth2#320
tldr is that IDP servers tend to not be fully compliant with how client
credentials are passed and have bespoke arrangements so anything goes
this enforces the standard implementation from the RFC and has it working
for any RFC compliant OIDC server
full info here golang/oauth2#320
supersedes #204