-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate vector unit #1928
Merged
Merged
Integrate vector unit #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryz123
force-pushed
the
vector-release
branch
8 times, most recently
from
July 30, 2024 23:03
678df64
to
c7aa223
Compare
jerryz123
force-pushed
the
vector-release
branch
7 times, most recently
from
August 6, 2024 04:08
f427414
to
82b545d
Compare
jerryz123
force-pushed
the
vector-release
branch
from
August 6, 2024 19:43
e777a53
to
b36cf88
Compare
dpgrubb13
reviewed
Aug 6, 2024
dpgrubb13
reviewed
Aug 6, 2024
dpgrubb13
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the few comment nits, LGTM.
jerryz123
force-pushed
the
vector-release
branch
from
August 6, 2024 20:42
a9b9a72
to
177504b
Compare
jerryz123
force-pushed
the
vector-release
branch
from
August 6, 2024 20:45
177504b
to
ca8ae71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?