Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support FIRRTL2 bridge + Chisel 6 annos for FireSim #2013

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Support FIRRTL2 bridge + Chisel 6 annos for FireSim #2013

merged 1 commit into from
Aug 22, 2024

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Aug 21, 2024 •
edited
Loading

Subsumes #1863.

  • Adds a new generator to FireChip that can generate Chisel3 FIRRTL (only used for FireChip)
  • FireSim now just uses Chisel3/Chisel6 compatible sources
  • Cleanups up as many references to Chisel3 in SBT + Scala sources

Finishes decoupling Chipyard and FireSim!

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@abejgonzalez abejgonzalez self-assigned this Aug 21, 2024
@abejgonzalez abejgonzalez mentioned this pull request Aug 21, 2024
Merged
11 tasks
@abejgonzalez abejgonzalez changed the title WIP: For FireSim, support FIRRTL2 bridge + Chisel 6 annos Support FIRRTL2 bridge + Chisel 6 annos for FireSim Aug 22, 2024
@abejgonzalez abejgonzalez changed the base branch from split-v1 to main August 22, 2024 06:02
@abejgonzalez abejgonzalez reopened this Aug 22, 2024
@abejgonzalez
For FireSim, support FIRRTL2 bridge + Chisel 6 annos
b20534f 
- All targets now compile w/ Chisel6
- Remove Chisel3 references as much as possible
- Add flag --emit-legacy-sfc to run SFC FIRRTL emission
jerryz123
jerryz123 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thanks for pushing this through.

@abejgonzalez abejgonzalez merged commit 51b66dd into main Aug 22, 2024
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryz123 jerryz123 jerryz123 approved these changes

@joonho3020 joonho3020 Awaiting requested review from joonho3020

Assignees

@abejgonzalez abejgonzalez

Labels
changelog:changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abejgonzalez @jerryz123