-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework url structure to accommodate graphql and new quizzes endpoints #619
Labels
Comments
Merged
bennettscience
added a commit
to bennettscience/canvasapi
that referenced
this issue
Apr 24, 2024
Updated docstring with class arguments Add check for _url without breaking `full_url` assignment See ucfopen#619 for more details. Following discussion on ucfopen#619, let the `Requester` be smarter about how to send a request. The user can specify either `new_quizzes` or `graphql` in the request to automatically use the correct endpoint. This moves repeated logic out of the class methods themselves.
bennettscience
added a commit
to bennettscience/canvasapi
that referenced
this issue
May 10, 2024
Based on ucfopen#612 and as an issue in ucfopen#619, this adds the `new_quizzes` and `graphql` keyword endpoints in the requester module. Methods which specify these locations will have the correct URL supplied by the library in the `_url` parameter for the requester.
bennettscience
added a commit
to bennettscience/canvasapi
that referenced
this issue
May 11, 2024
Based on ucfopen#612 and as an issue in ucfopen#619, this adds the `new_quizzes` and `graphql` keyword endpoints in the requester module. Methods which specify these locations will have the correct URL supplied by the library in the `_url` parameter for the requester. Calls from the `canvas`, `course`, and `new_quizzes` modules have been updated to use they keywords rather than a formatted URL string. All tests passing.
Thetwam
added a commit
that referenced
this issue
May 12, 2024
* Use `new_quizzes` and `graphql` keywords Based on #612 and as an issue in #619, this adds the `new_quizzes` and `graphql` keyword endpoints in the requester module. Methods which specify these locations will have the correct URL supplied by the library in the `_url` parameter for the requester. Calls from the `canvas`, `course`, and `new_quizzes` modules have been updated to use they keywords rather than a formatted URL string. All tests passing. * Better variable checks Rearrange to check for `_url` first, then assign the request url more explicitely. * fix silly typos --------- Co-authored-by: Matthew Emond <me@ucf.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Originally posted by @jonespm in #612 (comment)
The text was updated successfully, but these errors were encountered: