Use new_quizzes and graphql keywords
#653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on ucfopen#612 and as an issue in ucfopen#619, this adds the `new_quizzes` and `graphql` keyword endpoints in the requester module. Methods which specify these locations will have the correct URL supplied by the library in the `_url` parameter for the requester. Calls from the `canvas`, `course`, and `new_quizzes` modules have been updated to use they keywords rather than a formatted URL string. All tests passing.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #653 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 73 73
Lines 3732 3740 +8
=========================================
+ Hits 3732 3740 +8 ☔ View full report in Codecov by Sentry. |
Thetwam
requested changes
May 11, 2024
Rearrange to check for `_url` first, then assign the request url more explicitely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #612 and as an issue in #619, this adds the
new_quizzesandgraphqlkeyword endpoints in the requester module. Methods which specify these locations will have the correct URL supplied by the library in the_urlparameter for the requester.Calls from the
canvas,course, andnew_quizzesmodules have been updated to use they keywords rather than a formatted URL string.All tests passing.
Fixes #619.