Added help text to loading page #197
Conversation
There was a problem hiding this comment.
Hi Rachel,
Great work on your first PR! I know it was a big confusing navigating React/props/state/components, but I'm glad you were able to figure it out.
From a functionality perspective, this works exactly as intended, great work! I do have a few pointers on code consistency (using SASS instead of the style tag) and some nitpicky styling stuff, but if you're able to implement that (which shouldn't take too long) I think this looks good to merge. Solid work again, and let me know if you have any questions!
(as a quick side note, we would eventually want to write a test that confirms this behaviour. I'll either assign you another ticket to work on that if you're interested, or put you on another editor feature if you'd prefer that instead)
This is a quick follow up to @rzlien's PR (#197) adding a help text timer to `<Loading>`. It does three things: 1. renames the prop `showText` to `showHelpText`, and makes it inherit the value from an optional prop 2. uses `GH_REPO_NAME` constant instead of hard link for repo 3. adds tests to check for `showHelpText` prop validity and to check that the timer works (i.e. on mount, the help text is not there, and then after 2s, the help text shows up) Not super happy with how the timer test is written, since I wanted to use Jest's [mock timer calls](https://jestjs.io/docs/en/timer-mocks) - but I wasn't able to get them to work.
Added help text to loading page if loading takes more than 2 seconds. Allows users to submit issues to Github through a link on the loading page.