Adds Tests for <Loading>'s Timer + Minor Improvements #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't think I implemented this in the best way, but using Jest's mock timers didn't work as intended. not entirely sure why :(
krashanoff
suggested changes
Feb 22, 2020
krashanoff
approved these changes
Feb 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick follow up to @rzlien's PR (#197) adding a help text timer to
<Loading>. It does three things:showTexttoshowHelpText, and makes it inherit the value from an optional propGH_REPO_NAMEconstant instead of hard link for reposhowHelpTextprop validity and to check that the timer works (i.e. on mount, the help text is not there, and then after 2s, the help text shows up)Not super happy with how the timer test is written, since I wanted to use Jest's mock timer calls - but I wasn't able to get them to work.