Skip to content
This repository has been archived by the owner on Jan 28, 2022. It is now read-only.

Add horizontal rule #41

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Add horizontal rule #41

merged 1 commit into from
Jan 19, 2021

Conversation

jasonvarga
Copy link
Contributor

This adds support for <hr> tags.

However, the test doesn't pass. I'm not sure what needs to be done.

You should be able to have an hr inside a p, right? That test doesn't pass.
e.g. <p>foo<hr>bar</p>.

hr outside of a p seems to be ok.
e.g. <p>foo</p><hr><p>bar</p>

@jasonvarga
Copy link
Contributor Author

I put <p>foo<hr>bar</p> into https://validator.w3.org/nu/#textarea and it had an error, so I guess that's the answer. I'll update the code.

@sjclark
Copy link

sjclark commented Jan 18, 2021

I put <p>foo<hr>bar</p> into https://validator.w3.org/nu/#textarea and it had an error, so I guess that's the answer. I'll update the code.

hr's are intended to be structural / thematic breaks so I guess having them within a paragraph is sacrilege 🤷‍♂️
Thanks for PR'ing this!

@jasonvarga
Copy link
Contributor Author

Yeah after looking into it, I agree. But I just noticed it seemed to render just fine in the browser. Happy accident I suppose.

Copy link
Contributor

@hanspagel hanspagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! 👍 Thanks for the PR!

@hanspagel hanspagel merged commit 1ab69d7 into ueberdosis:main Jan 19, 2021
@jasonvarga jasonvarga deleted the hr branch January 19, 2021 13:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants