Skip to content
This repository has been archived by the owner on Jan 28, 2022. It is now read-only.

Add Horizontal Rule #46

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Add Horizontal Rule #46

merged 1 commit into from
Jan 19, 2021

Conversation

jasonvarga
Copy link
Contributor

This adds support for hr tags.

Tiptap can add them, but this package can't render them.

@jasonvarga
Copy link
Contributor Author

Also, see ueberdosis/html-to-prosemirror#41
If p's shouldn't be allowed to have hrs in them, we can remove the test for it.

Copy link
Contributor

@hanspagel hanspagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR’ing! 👍

@hanspagel hanspagel merged commit 255b067 into ueberdosis:main Jan 19, 2021
@jasonvarga jasonvarga deleted the hr branch January 19, 2021 13:50
@julesjanssen
Copy link

Looks like tiptap currently outputs a horizontalRule node type instead of the horizontal_rule as it's added here, is that correct?

@hanspagel
Copy link
Contributor

hanspagel commented May 12, 2021

Yes! The package here was developed or tiptap v1. It’s on my list to add support for tiptap v2, there even is a PR to add support, but I’m not decided about the implementation.

That said, you can use custom nodes and marks with this package to make it work with different names (example in the README)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants