extension/link: adds 'whenNotEditable' as option for openOnClick #3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@bdbch is there anything else I can do to move this forward? |
bdbch
added
Status: Review
Category: Open Source
Open
2 tasks
bdbch
previously approved these changes
Jun 23, 2023
* upstream/main: (399 commits) added new labels update links.yaml improve GitHub issue templates improve GitHub issue templates v2.1.11 Revert "v2.2.11" v2.2.11 feature(core): pass through paste event to pasteHandler `getAttributes` (#4354) v2.1.10 Fix React and Vue NodeView renderers not adding correct selection classes (#4452) v.2.1.9 chore: dont generate changelogs for rc versions fix: add missing attributes in extension-link (#4429) docs(react): fix typo on React installation code block (#4441) v2.1.8 v2.1.7 prevent opening link when clicking on selection containing a link (#4346) docs: complete hard break shortcuts docs: complete hard break shortcuts docs(collaboration): fix typo in collaboration.md ... Signed-off-by: Benjamin Kroeger <benjamin.kroeger@gmail.com> # Conflicts: # packages/extension-link/src/helpers/clickHandler.ts # packages/extension-link/src/link.ts
bdbch
approved these changes
Oct 10, 2023
|
LGTM @svenadlung need a review from you so we can push this to RC |
|
@bdbch @svenadlung how can I help to move this forward? |
svenadlung
approved these changes
Jan 10, 2024
|
just merged the latest main branch into this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows 'openOnClick' configuration to be set to 'whenNotEditable' so that links are not clickable while editing the content.
I have noticed that the editing experience is a little bumpy when you click on a 'link' marked text e.g. to modify the text - but then the link opens.
related issue: #4877