Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue: add test for mergeDeep fail #4088

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

YousefED
Copy link
Contributor

This test demonstrates there's a bug in the implementation of mergeDeep, which can cause other issues down the line

@netlify
Copy link

netlify bot commented May 29, 2023

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit e152183
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/66693f8054c79900089b034d
😎 Deploy Preview https://deploy-preview-4088--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nperez0111 nperez0111 force-pushed the develop branch 2 times, most recently from bcaef5c to 7e7ae19 Compare June 12, 2024 04:33
@nperez0111 nperez0111 marked this pull request as ready for review June 12, 2024 06:25
Copy link
Contributor

@nperez0111 nperez0111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handled the issue with some simpler logic, thanks for pointing it out

@nperez0111 nperez0111 merged commit fe78faa into ueberdosis:develop Jun 12, 2024
14 checks passed
@nperez0111 nperez0111 mentioned this pull request Jul 13, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants