Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): tiptap v2.5 #5341

Merged
merged 115 commits into from
Jul 14, 2024
Merged

chore(release): tiptap v2.5 #5341

merged 115 commits into from
Jul 14, 2024

Conversation

nperez0111
Copy link
Contributor

Changes Overview

Implementation Approach

Testing Done

Verification Steps

Additional Notes

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

bdbch and others added 30 commits January 11, 2024 13:39
…boration (#4976)

* extension-collaboration: allow passing ySyncOptions

* fixes import
Co-authored-by: Pepijn Hillemans <pepijn.hillemans@cm.com>
nperez0111 and others added 15 commits July 3, 2024 20:54
…ard compatible (#5161)

* fix: default to rendering the editor immediately, while staying backward compatible

* feat: add `useEditorWithState` hook for extracting state and editor instance simultaneously

* feat(react): add `useEditorState` hook for subscribing to selected editor state

* docs: add an example to show the concept

* chore: add changeset
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
So that TypeScript will resolve the non-nullable one first, unless the editor is nullable, in which case the other one will resolve.
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…5338)

This forces the editor to re-use the editor instance that existed prior to an unmount and remount of the same component.
This fixes a bug in `React.StrictMode` introduced with the latest performance updates by PR #5161
Copy link

changeset-bot bot commented Jul 13, 2024

⚠️ No Changeset found

Latest commit: 82fbabc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jul 13, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 82fbabc
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/6693dc3e151e9400088de043
😎 Deploy Preview https://deploy-preview-5341--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@bdbch bdbch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a question regarding the changesets pre.json

.changeset/pre.json Outdated Show resolved Hide resolved
@nperez0111 nperez0111 merged commit 82fbabc into main Jul 14, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.