Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chgres_cube circular dependency in write_data and atmosphere.F90/surface.F90 #459

Closed
kgerheiser opened this issue Apr 26, 2021 · 0 comments
Closed

chgres_cube circular dependency in write_data and atmosphere.F90/surface.F90 #459

kgerheiser opened this issue Apr 26, 2021 · 0 comments
Assignees
@kgerheiser @GeorgeGayno-NOAA
Labels
bug Something isn't working

Comments

@kgerheiser
Copy link
Contributor

I put write_data.F90 into a module to squash warnings (and because it's good practice) about undefined functions without the external attribute, and found a circular dependency.

Surface/Atmosphere call write_data routines, and write_data use target grid fields from them.

I propose to move the target fields into sfc_target_data, and sfc_target_data modules that can be commonly used by write_data, just like input_data.F90.
@kgerheiser kgerheiser added the bug Something isn't working label Apr 26, 2021
@GeorgeGayno-NOAA GeorgeGayno-NOAA self-assigned this Feb 14, 2022
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Feb 14, 2022
@GeorgeGayno-NOAA
Move atmospheric target fields and the associated cleanup
7cc5217 
routine to its own module.

Fixes ufs-community#459.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Feb 14, 2022
@GeorgeGayno-NOAA
Add new module to hold atmospheric target data.
0928192 
Fixes ufs-community#459.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Feb 14, 2022
@GeorgeGayno-NOAA
Move surface target fields to their own module.
ff68778 
Fixes ufs-community#459.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Feb 15, 2022
@GeorgeGayno-NOAA
Move additional target variables to atm_target_data.
df45e7b 
Convert write_data.F90 to a Fortran module.

Fixes ufs-community#459
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Feb 15, 2022
@GeorgeGayno-NOAA
Some cleanup of atmospheric component.
7534d10 
Fixes ufs-community#459
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Feb 15, 2022
@GeorgeGayno-NOAA
Rename module that contains the atmospheric target esmf
1824060 
fields.

Fixes ufs-community#459
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Feb 15, 2022
@GeorgeGayno-NOAA
Add Doxygen to atmosphere_target_data.F90.
c9af07f 
Fixes ufs-community#459.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Feb 15, 2022
@GeorgeGayno-NOAA
Update write_data.F90 to use only the target atmospheric
6432240 
fields it needs.

Fixes ufs-community#459.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Feb 15, 2022
@GeorgeGayno-NOAA
Rename 'sfc_target_data.F90' as 'surface_target_data.F90'.
58e874e 
Add doxygen where needed. Do some general clean up.

Fixes ufs-community#459.
@GeorgeGayno-NOAA GeorgeGayno-NOAA mentioned this issue Feb 15, 2022
Merged
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Feb 18, 2022
@GeorgeGayno-NOAA
Merge branch 'develop' into bugfix/circular
3ebb93a 
Fixes ufs-community#459.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Mar 23, 2022
@GeorgeGayno-NOAA
Merge branch 'develop' into bugfix/circular
1a2d4ec 
Fixes ufs-community#459
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Mar 23, 2022
@GeorgeGayno-NOAA
Merge remote-tracking branch 'upstream/develop' into bugfix/circular
a196559 
Fixes ufs-community#459.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kgerheiser kgerheiser

@GeorgeGayno-NOAA GeorgeGayno-NOAA

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kgerheiser @GeorgeGayno-NOAA