Eliminate circular dependency in chgres_cube #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
routine to its own module. Fixes ufs-community#459.
Convert write_data.F90 to a Fortran module. Fixes ufs-community#459
fields it needs. Fixes ufs-community#459.
Add doxygen where needed. Do some general clean up. Fixes ufs-community#459.
|
The consistency tests also passed on Orion, Jet, Venus and Surge. |
|
@kgerheiser, given your proposed fix to this problem, do you mind reviewing @GeorgeGayno-NOAA's PR? Thank you! |
LarissaReames-NOAA
approved these changes
Feb 17, 2022
JeffBeck-NOAA
approved these changes
Feb 18, 2022
|
I would like to merge #625 first. |
|
Reran the |
|
@kgerheiser You were the one who discovered this bug. Do you want to give your review? |
kgerheiser
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Remove circular dependency between write_data.F90 and modules surface.F90 and atmosphere.F90
TESTS CONDUCTED:
Consistency tests passed on Hera. Tests on other machines are pending.
DEPENDENCIES:
None.
DOCUMENTATION:
N/A
ISSUE:
#459
CONTRIBUTORS:
Many thanks to @kgerheiser for finding this bug and suggesting a solution.