Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smoke, dust, and MYNN updates #54

Merged
merged 28 commits into from
Mar 27, 2023
Merged

Smoke, dust, and MYNN updates #54

merged 28 commits into from
Mar 27, 2023

Conversation

SamuelTrahanNOAA
Copy link
Collaborator

@SamuelTrahanNOAA SamuelTrahanNOAA commented Mar 15, 2023 •
edited
Loading

RRFS-Smoke is improved, cleaned, and rebranded as RRFS-SD. Now with smoke, dust, and coarsepm tracer handling, it adds dry deposition velocity to MYNN-EDMF, updates the smoke/dust direct and indirect feedback. There are bug fixes: switch to non-aerosol-aware in the GF scheme and correct emission bug in FENGSHA.

Also included are MYNN updates from #43

These changes are from @haiqinli and @joeolson42.

Related issue: ufs-community/ufs-weather-model#1659

joeolson42 and others added 17 commits February 28, 2023 22:10
@joeolson42
MYNN updates
b558a09
@joeolson42
updating mynnedmf wrapper
4e79188
@joeolson42
Precision (kind_phys) changes to address reviewer comments
3d36fb2
@joeolson42
fixes for Grants comments and suggestions
0e20bda
@haiqinli
"merge RRFS-SD from the GSL repository to the community repository"
c9c973a
@haiqinli
"include the MYNN-EDMF update from PR NCAR#43"
40f9361
@SamuelTrahanNOAA
bug fixes from sam to get most regression tests to pass
9c88396
@haiqinli
"include updates from Sam and Haiqin"
118f72c
@SamuelTrahanNOAA
do not dereference a null pointer
aa3c16b
@SamuelTrahanNOAA
do not initialize vdep
67b0511
@SamuelTrahanNOAA
revert accidental change
50c4f1b
@SamuelTrahanNOAA
1.2 GB of messages is a bit too much.
14557a5
@joeolson42
More consistent logic for NSSL mp (mixing snow)
0b369ef
@joeolson42
Merge branch 'ufs/dev' into mynn_01March
138a0ef
@joeolson42
removing snow mixing from nssl-mp
4cc7227
@SamuelTrahanNOAA
merge joe's mynn_01March branch
1f37f3e
@haiqinli
"update MYNN coupling to nssl-mp from PR NCAR#43"
6964aab
This was referenced Mar 15, 2023
Merged
Merged
dustinswales
dustinswales requested changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@dustinswales dustinswales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Some minor suggestions.

physics/rrtmgp_aerosol_optics.meta Outdated Show resolved Hide resolved
physics/sgscloud_radpre.F90 Show resolved Hide resolved
physics/smoke_dust/module_smoke_plumerise.F90 Outdated Show resolved Hide resolved
physics/smoke_dust/module_smoke_plumerise.F90 Outdated Show resolved Hide resolved
physics/smoke_dust/rrfs_smoke_wrapper.F90 Show resolved Hide resolved
physics/smoke_dust/rrfs_smoke_postpbl.F90 Show resolved Hide resolved
@SamuelTrahanNOAA
Copy link
Collaborator Author

@dustinswales - I just merged a branch from @haiqinli that should resolve the problems you found, other than the one you said should be fixed in a follow-up PR instead.

@grantfirl
Copy link
Collaborator

Nice work @haiqinli and @joeolson42 -- only minor comments really. There is room for computational improvement with dividing by physical constants within N-nested loops, but I'm not going to hold up your progress for that (and it might be optimized by the compiler anyway?). I'll approve once comments are addressed.

@SamuelTrahanNOAA
Copy link
Collaborator Author

@grantfirl - @haiqinli is preparing some changes to address your comments and I'll merge them from his branch as soon as possible.

@grantfirl grantfirl mentioned this pull request Mar 23, 2023
Closed
37 tasks
@SamuelTrahanNOAA
Copy link
Collaborator Author

@grantfirl - I just merged changes from @haiqinli to fix the problems you found, and I also updated to the top of ufs/dev.

grantfirl
grantfirl approved these changes Mar 24, 2023
View reviewed changes
Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the prompt updates @haiqinli @SamuelTrahanNOAA .

@grantfirl
Copy link
Collaborator

@dustinswales You'll need to re-review since you requested changes.

dustinswales
dustinswales approved these changes Mar 24, 2023
View reviewed changes
Copy link
Collaborator

@dustinswales dustinswales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for making the requested changes.

@jkbk2004
Copy link

@grantfirl test was one on ufs-community/ufs-weather-model#1658. we can merge in this pr.

@grantfirl grantfirl merged commit 6f06ad9 into ufs-community:ufs/dev Mar 27, 2023
@grantfirl grantfirl mentioned this pull request Mar 31, 2023
Merged
grantfirl pushed a commit that referenced this pull request Jul 18, 2023
@HelinWei-NOAA
Merge pull request #54 from HelinWei-NOAA/fix_tq2m_diagnoahmp
d2fd9d0 
sync with the latest ufs/dev branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiqinli haiqinli haiqinli left review comments

@yangfanglin yangfanglin yangfanglin left review comments

@dustinswales dustinswales dustinswales approved these changes

@grantfirl grantfirl grantfirl approved these changes

@Qingfu-Liu Qingfu-Liu Qingfu-Liu approved these changes

@ChunxiZhang-NOAA ChunxiZhang-NOAA Awaiting requested review from ChunxiZhang-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@SamuelTrahanNOAA @grantfirl @jkbk2004 @dustinswales @Qingfu-Liu @haiqinli @yangfanglin @joeolson42