Smoke, dust, and MYNN updates

[SamuelTrahanNOAA]

Description

RRFS-Smoke is improved, cleaned, and rebranded as RRFS-SD. Now with smoke, dust, and coarsepm tracer handling, it adds dry deposition velocity to MYNN-EDMF, updates the smoke/dust direct and indirect feedback. There are bug fixes: switch to non-aerosol-aware in the GF scheme and correct emission bug in FENGSHA. RRFS CONUS 13km tests all run smoke, and there is just one field_table.

These changes are from @haiqinli and @joeolson42, except the regression tests, which are from me.

Top of commit queue on: TBD

Input data additions/changes

• There will be new input data.
• Input data will be updated.

Input data is here:

/scratch2/BMC/wrfruc/Samuel.Trahan/gsl-pr/HaiqinPR/RT/NEMSfv3gfs/input-data-20221101

Updates:

FV3_aeroclim/ - some aerosol climatology data
FV3_input_data_conus13km/INPUT/ - a few new files

Anticipated changes to regression tests:

• Changes are expected to the following tests: smoke tests, and anything that MYNN-EDMF update #1636 changes

Subcomponents involved:

• AQM
• CDEPS
• CICE
• CMEPS
• CMakeModules
• FV3
• GOCART
• HYCOM
• MOM6
• NOAHMP
• WW3
• stochastic_physics
• none

Combined with PR's (If Applicable):

This PR already includes #1636 since it requires those changes.

Commit Queue Checklist:

• Link PR's from all sub-components involved
• Confirm reviews completed in sub-component PR's
• Add all appropriate labels to this PR.
• Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
• Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

• closes issue for RRFS-SD upgrade #1659
• waiting on Smoke, dust, and MYNN updates ccpp-physics#54
• waiting on Smoke, dust, and MYNN updates NOAA-EMC/fv3atm#635

Testing Day Checklist:

• This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
• Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

• RDHPCS
  • Intel
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • GNU
    • Hera
    • Cheyenne
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
  • Completed
• opnReqTest
  • N/A
  • Log attached to comment

[zach1221]

Good morning, @SamuelTrahanNOAA . I think we're ready to start merge process. Are you able to merge your ccpp PR?

[SamuelTrahanNOAA]

Are you able to merge your ccpp PR?

No, but if you post a message on that PR's page asking for it to be merged, someone is likely to respond soon.

[jkbk2004]

I left a message in ccpp pr.

[junwang-noaa]

@SamuelTrahanNOAA Since we have the threads/decomp/restart/debug for the tests/tests/rrfs_smoke_conus13km_hrrr_warm test, we may not also need threads/decomp tests for tests/tests/rrfs_smoke_conus13km_hrrr_warm_debug. Maybe this can be cleaned up later? Thanks

[SamuelTrahanNOAA]

Since we have the threads/decomp/restart/debug for the tests/tests/rrfs_smoke_conus13km_hrrr_warm test, we may not also need threads/decomp tests for tests/tests/rrfs_smoke_conus13km_hrrr_warm_debug. Maybe this can be cleaned up later? Thanks

I want to leave the extra variants for a while, for investigating the reproducibility issues in the RRFS. That's why I put them in.

[junwang-noaa]

I see. So the decomp and restart tests do not work at this time. We expect additional PRs to fix the issue.

[SamuelTrahanNOAA]

I see. So the decomp and restart tests do not work at this time. We expect additional PRs to fix the issue.

They're operational requirements, so they have to be fixed eventually.

[jkbk2004]

@SamuelTrahanNOAA fv3 pr was merged. We can merge the pr with submodule pointer update and reverting change in gitmodules.

[SamuelTrahanNOAA]

Somehow I dismissed @DusanJovic-NOAA's stale review. I don't recall doing that... was it automatic?

[SamuelTrahanNOAA]

The .gitmodules matches develop, and FV3 points to the NOAA-EMC fv3atm develop.

[grantfirl]

Somehow I dismissed @DusanJovic-NOAA's stale review. I don't recall doing that... was it automatic?

Yep, it's automatic when you push a new commit after a review approval. Perhaps there is a setting somewhere...

[BrianCurtis-NOAA]

Somehow I dismissed @DusanJovic-NOAA's stale review. I don't recall doing that... was it automatic?
Yep, it's automatic when you push a new commit after a review approval. Perhaps there is a setting somewhere...

@SamuelTrahanNOAA This is correct. It's to ensure the latest code changes are getting reviewed. EPIC can change it in the repo settings as they see fit.