-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/singularity addition #686
Merged
jkbk2004
merged 10 commits into
ufs-community:develop
from
EdwardSnyder-NOAA:feature/singularity-addition
Mar 4, 2022
Merged
Feature/singularity addition #686
jkbk2004
merged 10 commits into
ufs-community:develop
from
EdwardSnyder-NOAA:feature/singularity-addition
Mar 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we need to merge the change and delete this file later.
EdwardSnyder-NOAA
requested review from
mkavulich,
gsketefian,
JeffBeck-NOAA,
RatkoVasic-NOAA,
BenjaminBlake-NOAA,
ywangwof,
chan-hoo,
panll,
christinaholtNOAA,
christopherwharrop-noaa,
danielabdi-noaa,
mark-a-potts,
jkbk2004,
willmayfield,
jwolff-ncar and
dmwright526
as code owners
March 2, 2022 19:23
gsketefian
reviewed
Mar 2, 2022
gsketefian
reviewed
Mar 2, 2022
gsketefian
reviewed
Mar 2, 2022
gsketefian
reviewed
Mar 2, 2022
gsketefian
reviewed
Mar 2, 2022
gsketefian
reviewed
Mar 2, 2022
gsketefian
approved these changes
Mar 4, 2022
gsketefian
approved these changes
Mar 4, 2022
Removed empty string MET and test variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed empty string MET and test data variables.
jkbk2004
approved these changes
Mar 4, 2022
jkbk2004
added a commit
to ufs-community/ufs-srweather-app
that referenced
this pull request
Mar 8, 2022
* Create build_singularity_gnu.env * Create wflow_singularity.env * Updated regional_workflow pointer: ES fork branch * Update build_singularity_gnu.env * Update Externals.cfg Updated the Regional Workflow repo as the accompanied PR (ufs-community/regional_workflow#686) has been merged into the develop branch. * Update Externals.cfg updated regional workflow hash * Update build_singularity_gnu.env Co-authored-by: JONG KIM <jong.kim@noaa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Added singularity container option.
TESTS CONDUCTED:
Test were conducted on Orion and Parallel Works Cloud environments.
DEPENDENCIES:
Add any links to external PRs. For example:
DOCUMENTATION:
Future PR's will include text about running the app with the singularity container.
ISSUE (optional):
CONTRIBUTORS (optional):
@jkbk2004 @mark-a-potts