Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Fixed file path for FIXgsm #795

Conversation

EdwardSnyder-NOAA
Copy link
Collaborator

DESCRIPTION OF CHANGES:

Added back the fix_dir_input_grid variable to the exregional_make_ics.sh and exregional_make_lbcs.sh scripts.

TESTS CONDUCTED:

Ran test on Hera and more tests will be conducted through the Jenkins pipeline.

DEPENDENCIES:

None.

DOCUMENTATION:

No documentation changes needed.

ISSUE (optional):

CONTRIBUTORS (optional):

@mark-a-potts

@EdwardSnyder-NOAA EdwardSnyder-NOAA changed the title added 'fix_dir_input_grid' var [Release] Fixed file path for FIXgsm Jun 14, 2022
Copy link
Collaborator

@mark-a-potts mark-a-potts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I am not sure we need the parameter in exregional_make_ics.sh, but we can test it to make sure it doesn't break anything. Can you also switch over all the "develop" paths in ush/machine/*.sh to "v2p0" and we can combine two fixes into one?

@EdwardSnyder-NOAA
Copy link
Collaborator Author

This looks good. I am not sure we need the parameter in exregional_make_ics.sh, but we can test it to make sure it doesn't break anything. Can you also switch over all the "develop" paths in ush/machine/*.sh to "v2p0" and we can combine two fixes into one?

Made the changes as requested.

@EdwardSnyder-NOAA EdwardSnyder-NOAA dismissed mark-a-potts’s stale review June 15, 2022 00:37

The review has been addressed

@@ -443,6 +443,7 @@ list file has not specified for this external LBC model (EXTRN_MDL_NAME_LBCS):
#
settings="
'config': {
'fix_dir_input_grid': ${FIXgsm},
Copy link
Collaborator

@gsketefian gsketefian Jun 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EdwardSnyder-NOAA @mark-a-potts Just curious if you know whether this line was necessary to fix the make_lbcs failures. If it was, it means something must have changed either in chgres_cube or the fix files. (I always thought the external model data files already contained a description of the external model's grid.) To keep the namelist as simple as possible, it would be good to remove it if it's not really needed. Not necessarily for this PR; I'm thinking more about when we move these changes into develop. Thanks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From our testing, it was definitely needed. I am not sure that it is needed for the exregional_make_ics.sh script, though. Without that line in the namelist, chgres_cube was looking for NULL/latlon.grid3.nc (or something very similar) and segfaulting when it could not open the file.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After digging into this a bit more, looks like this line was removed very recently from both files in PR #775. I guess that was needed due to a change in UFS_UTILS (not sure what), but the release/public-v2 branch still needs the lines (although I haven't actually tested the develop branch with the two tests that were failing in the release branch to see if it works; maybe I'll give that a shot now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants