Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Fixed file path for FIXgsm #795

Merged
merged 3 commits into from
Jun 15, 2022
Merged

[Release] Fixed file path for FIXgsm #795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65f4e52
added 'fix_dir_input_grid' var
EdwardSnyder-NOAA Jun 14, 2022
ccf6e0f
added filename
EdwardSnyder-NOAA Jun 14, 2022
8d15af5
update file paths to v2p0
EdwardSnyder-NOAA Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/exregional_make_ics.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,7 @@ fi
#
settings="
'config': {
'fix_dir_input_grid': ${FIXgsm},
'fix_dir_target_grid': ${FIXLAM},
'mosaic_file_target_grid': ${FIXLAM}/${CRES}${DOT_OR_USCORE}mosaic.halo$((10#${NH4})).nc,
'orog_dir_target_grid': ${FIXLAM},
Expand Down
1 change: 1 addition & 0 deletions scripts/exregional_make_lbcs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,7 @@ list file has not specified for this external LBC model (EXTRN_MDL_NAME_LBCS):
#
settings="
'config': {
'fix_dir_input_grid': ${FIXgsm},
Copy link
Collaborator

@gsketefian gsketefian Jun 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EdwardSnyder-NOAA @mark-a-potts Just curious if you know whether this line was necessary to fix the make_lbcs failures. If it was, it means something must have changed either in chgres_cube or the fix files. (I always thought the external model data files already contained a description of the external model's grid.) To keep the namelist as simple as possible, it would be good to remove it if it's not really needed. Not necessarily for this PR; I'm thinking more about when we move these changes into develop. Thanks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From our testing, it was definitely needed. I am not sure that it is needed for the exregional_make_ics.sh script, though. Without that line in the namelist, chgres_cube was looking for NULL/latlon.grid3.nc (or something very similar) and segfaulting when it could not open the file.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After digging into this a bit more, looks like this line was removed very recently from both files in PR #775. I guess that was needed due to a change in UFS_UTILS (not sure what), but the release/public-v2 branch still needs the lines (although I haven't actually tested the develop branch with the two tests that were failing in the release branch to see if it works; maybe I'll give that a shot now).

'fix_dir_target_grid': ${FIXLAM},
'mosaic_file_target_grid': ${FIXLAM}/${CRES}${DOT_OR_USCORE}mosaic.halo$((10#${NH4})).nc,
'orog_dir_target_grid': ${FIXLAM},
Expand Down
4 changes: 3 additions & 1 deletion ...trn_mdls_suites_community/config.grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,12 @@ CCPP_PHYS_SUITE="FV3_WoFS_v0"
EXTRN_MDL_NAME_ICS="HRRR"
EXTRN_MDL_NAME_LBCS="RAP"
USE_USER_STAGED_EXTRN_FILES="TRUE"
EXTRN_MDL_FILES_ICS=( '{yy}{jjj}{hh}00{fcst_hr:02d}00' )
EXTRN_MDL_FILES_LBCS=( '{yy}{jjj}{hh}00{fcst_hr:02d}00' )

DATE_FIRST_CYCL="20200801"
DATE_LAST_CYCL="20200801"
CYCL_HRS=( "00" )

FCST_LEN_HRS="6"
LBC_SPEC_INTVL_HRS="3"
LBC_SPEC_INTVL_HRS="6"
2 changes: 1 addition & 1 deletion ush/machine/cheyenne.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ QUEUE_HPSS=${QUEUE_HPSS:-"regular"}
QUEUE_FCST=${QUEUE_FCST:-"regular"}

# UFS SRW App specific paths
staged_data_dir="/glade/p/ral/jntp/UFS_SRW_App/develop"
staged_data_dir="/glade/p/ral/jntp/UFS_SRW_App/v2p0"
FIXgsm=${FIXgsm:-"${staged_data_dir}/fix/fix_am"}
FIXaer=${FIXaer:-"${staged_data_dir}/fix/fix_aer"}
FIXlut=${FIXlut:-"${staged_data_dir}/fix/fix_lut"}
Expand Down
2 changes: 1 addition & 1 deletion ush/machine/gaea.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ QUEUE_FCST=${QUEUE_DEFAULT:-"normal"}
WTIME_MAKE_LBCS="00:60:00"

# UFS SRW App specific paths
staged_data_dir="/lustre/f2/pdata/ncep/UFS_SRW_App/develop"
staged_data_dir="/lustre/f2/pdata/ncep/UFS_SRW_App/v2p0"
FIXgsm=${FIXgsm:-"${staged_data_dir}/fix/fix_am"}
FIXaer=${FIXaer:-"${staged_data_dir}/fix/fix_aer"}
FIXlut=${FIXlut:-"${staged_data_dir}/fix/fix_lut"}
Expand Down
2 changes: 1 addition & 1 deletion ush/machine/hera.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ PARTITION_FCST=${PARTITION_FCST:-"hera"}
QUEUE_FCST=${QUEUE_FCST:-"batch"}

# UFS SRW App specific paths
staged_data_dir="/scratch2/BMC/det/UFS_SRW_App/develop"
staged_data_dir="/scratch2/BMC/det/UFS_SRW_App/v2p0"
FIXgsm=${FIXgsm:-"${staged_data_dir}/fix/fix_am"}
FIXaer=${FIXaer:-"${staged_data_dir}/fix/fix_aer"}
FIXlut=${FIXlut:-"${staged_data_dir}/fix/fix_lut"}
Expand Down
2 changes: 1 addition & 1 deletion ush/machine/jet.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ PARTITION_FCST=${PARTITION_FCST:-"sjet,vjet,kjet,xjet"}
QUEUE_FCST=${QUEUE_FCST:-"batch"}

# UFS SRW App specific paths
staged_data_dir="/mnt/lfs4/BMC/wrfruc/UFS_SRW_App/develop"
staged_data_dir="/mnt/lfs4/BMC/wrfruc/UFS_SRW_App/v2p0"
FIXgsm=${FIXgsm:-"${staged_data_dir}/fix/fix_am"}
FIXaer=${FIXaer:-"${staged_data_dir}/fix/fix_aer"}
FIXlut=${FIXlut:-"${staged_data_dir}/fix/fix_lut"}
Expand Down
2 changes: 1 addition & 1 deletion ush/machine/noaacloud.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ NCORES_PER_NODE=${NCORES_PER_NODE:-36}
SCHED=${SCHED:-"slurm"}

# UFS SRW App specific paths
staged_data_dir="/contrib/EPIC/UFS_SRW_App/develop"
staged_data_dir="/contrib/EPIC/UFS_SRW_App/v2p0"
FIXgsm=${FIXgsm:-"${staged_data_dir}/fix/fix_am"}
FIXaer=${FIXaer:-"${staged_data_dir}/fix/fix_aer"}
FIXlut=${FIXlut:-"${staged_data_dir}/fix/fix_lut"}
Expand Down
2 changes: 1 addition & 1 deletion ush/machine/odin.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ function file_location() {
external_model=${1}
external_file_fmt=${2}

staged_data_dir="/scratch/ywang/UFS_SRW_App/develop"
staged_data_dir="/scratch/ywang/UFS_SRW_App/v2p0"

location=""
case ${external_model} in
Expand Down
2 changes: 1 addition & 1 deletion ush/machine/orion.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ PARTITION_FCST=${PARTITION_FCST:-"orion"}
QUEUE_FCST=${QUEUE_FCST:-"batch"}

# UFS SRW App specific paths
staged_data_dir="/work/noaa/fv3-cam/UFS_SRW_App/develop"
staged_data_dir="/work/noaa/fv3-cam/UFS_SRW_App/v2p0"
FIXgsm=${FIXgsm:-"${staged_data_dir}/fix/fix_am"}
FIXaer=${FIXaer:-"${staged_data_dir}/fix/fix_aer"}
FIXlut=${FIXlut:-"${staged_data_dir}/fix/fix_lut"}
Expand Down
4 changes: 2 additions & 2 deletions ush/machine/stampede.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ function file_location() {
external_model=${1}
external_file_fmt=${2}

staged_data_dir="/work2/00315/tg455890/stampede2/UFS_SRW_App/develop"
staged_data_dir="/work2/00315/tg455890/stampede2/UFS_SRW_App/v2p0"

location=""
case ${external_model} in
Expand Down Expand Up @@ -62,7 +62,7 @@ PARTITION_FCST=${PARTITION_FCST:-"normal"}
QUEUE_FCST=${QUEUE_FCST:-"normal"}

# UFS SRW App specific paths
staged_data_dir="/work2/00315/tg455890/stampede2/UFS_SRW_App/develop"
staged_data_dir="/work2/00315/tg455890/stampede2/UFS_SRW_App/v2p0"
FIXgsm=${FIXgsm:-"${staged_data_dir}/fix/fix_am"}
FIXaer=${FIXaer:-"${staged_data_dir}/fix/fix_aer"}
FIXlut=${FIXlut:-"${staged_data_dir}/fix/fix_lut"}
Expand Down
2 changes: 1 addition & 1 deletion ush/machine/wcoss_dell_p3.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ QUEUE_HPSS=${QUEUE_HPSS:-"dev_transfer"}
QUEUE_FCST=${QUEUE_FCST:-"dev"}

# UFS SRW App specific paths
staged_data_dir="/gpfs/dell2/emc/modeling/noscrub/UFS_SRW_App/develop"
staged_data_dir="/gpfs/dell2/emc/modeling/noscrub/UFS_SRW_App/v2p0"
FIXgsm=${FIXgsm:-"${staged_data_dir}/fix/fix_am"}
FIXaer=${FIXaer:-"${staged_data_dir}/fix/fix_aer"}
FIXlut=${FIXlut:-"${staged_data_dir}/fix/fix_lut"}
Expand Down