Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Angular doesn't compile when @Input/@Output are private #308

Merged
merged 11 commits into from
Sep 30, 2020
Merged

Fix Angular doesn't compile when @Input/@Output are private #308

merged 11 commits into from
Sep 30, 2020

Conversation

amine-bambrik-p8
Copy link
Contributor

Angular complain about passing data to @input fields that are private

What I have done is:

  • instead of private use public getters without setters for @Output and return an alternative private field
  • instead of private use public setters without getters for @Input and set an alternative private field
  • might need to prefix the new private fields with _ prefix for consistency

I apologize for the bad pull request message this is my first ever pull request

@amine-bambrik-p8
Fix Angular doesn't compile when @Input/@output are private
2f84b88 
instead of private use public getters without setters for @output and return an alternative private field
instead of private use public setters without getters for @input and set an alternative private field
might need to prefix the new private fields with _ prefix for consistency
@amine-bambrik-p8
Merge pull request #1 from amine-bambrik-p8/fix-compile-error-private-io
5c2ff4f 
Fix Angular doesn't compile when @Input/@output are private
@amine-bambrik-p8
Fix typo
cbbbbdd
@amine-bambrik-p8
Fix lint problem
69dbfad
@amine-bambrik-p8
Fix linting problem
8f7b4df
@amine-bambrik-p8
Fix add generic type
533b932 
linter complain about missing generic type
@santoshyadavdev santoshyadavdev merged commit eb7923e into uiuniversal:master Sep 30, 2020
@santoshyadavdev
Copy link
Member

Thanks a lot @amine-bambrik-p8 for contributing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santoshyadavdev santoshyadavdev santoshyadavdev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amine-bambrik-p8 @santoshyadavdev