Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Angular doesn't compile when @Input/@Output are private #308

Merged
merged 11 commits into from
Sep 30, 2020
Merged

Fix Angular doesn't compile when @Input/@Output are private #308

Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2f84b88
Fix Angular doesn't compile when @Input/@Output are private
amine-bambrik-p8 Sep 25, 2020
5c2ff4f
Merge pull request #1 from amine-bambrik-p8/fix-compile-error-private-io
amine-bambrik-p8 Sep 25, 2020
cbbbbdd
Fix typo
amine-bambrik-p8 Sep 25, 2020
69dbfad
Fix lint problem
amine-bambrik-p8 Sep 25, 2020
8f7b4df
Fix linting problem
amine-bambrik-p8 Sep 25, 2020
533b932
Fix add generic type
amine-bambrik-p8 Sep 25, 2020
52977cf
Update change fields to public
amine-bambrik-p8 Sep 28, 2020
bf74fe4
Fix lint problem
amine-bambrik-p8 Sep 28, 2020
ac78803
Fix lint problems
amine-bambrik-p8 Sep 28, 2020
3c6cb6e
Fix lint problems
amine-bambrik-p8 Sep 28, 2020
628343c
fix remove duplicate comment
amine-bambrik-p8 Sep 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions projects/ngu-carousel/src/lib/ngu-carousel/ngu-carousel.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,26 @@ export class NguCarousel<T> extends NguCarouselStore
private withAnim = true;
activePoint: number;
isHovered = false;
private inputs: NguCarouselConfig;
// tslint:disable-next-line:no-input-rename
@Input('inputs')
amine-bambrik-p8 marked this conversation as resolved.
Show resolved Hide resolved
set publicInputs(inputs: NguCarouselConfig) {
this.inputs = inputs;
}
private carouselLoad = new EventEmitter<any>();
// tslint:disable-next-line:no-input-rename
@Output('carouselLoad')
amine-bambrik-p8 marked this conversation as resolved.
Show resolved Hide resolved
get publicCarouselLoad(): EventEmitter<any> {
return this.carouselLoad;
}

@Input() private inputs: NguCarouselConfig;
@Output() private carouselLoad = new EventEmitter();

private onMove = new EventEmitter<NguCarousel<T>>();
// tslint:disable-next-line:no-output-on-prefix
amine-bambrik-p8 marked this conversation as resolved.
Show resolved Hide resolved
@Output() private onMove = new EventEmitter<NguCarousel<T>>();
// tslint:disable-next-line:no-input-rename
@Output('onMove')
amine-bambrik-p8 marked this conversation as resolved.
Show resolved Hide resolved
get publicOnMove(): EventEmitter<NguCarousel<T>> {
return this.onMove;
}
// isFirstss = 0;
arrayChanges: IterableChanges<{}>;
carouselInt: Subscription;
Expand Down