Develop combine

[shimwell]

Proposed changes

This brings in recent changes that have been combined

3d mesh tallies
automatic movement of the trelis script for neutronics simulations
type hinting on lots of classes and functions

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Code refactoring
• Documentation Update (if none of the other choices apply)
• New tests

Checklist

• Pep8 applied
• Unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[shimwell]

I think that is about as many tests that can be added without testing the importErrors

[shimwell]

John has a few more tests in progress #680 which could help raise the coverage a bit more

[RemDelaporteMathurin]

John has a few more tests in progress #680 which could help raise the coverage a bit more

Super! I think the coverage is fine tbh. This can surely be merged in if needed. The question was more on "should we have these try/except imports or not" but this can be answered later :-)

[shimwell]

@billingsley-john that last commit replaced nested tests with discrete unit tests for the test_NeutronicModel

[shimwell]

Thanks for the tests refactoring John, I think this is ready to merge. I will have a go at the import testing at some point and see if it can be done in a simple manner

[shimwell]

I just added a few more suggestions for the pullrequest.com review. Making steady progress getting through them 👍

[shimwell]

The pullrequest.com suggestions included changing a few ValueErrors to TypeErrors. I forgot to follow this up in the tests so that is why the tests failed. I think they are all fixed now :-)

[RemDelaporteMathurin]

@shimwell any idea why the GA CI fails ?

[shimwell]

@shimwell any idea why the GA CI fails ?

I think it was due to a small change in the OpenMC DAGMC interface that is fixed now openmc-dev/openmc#1747

I am now rerunning the CI

[shimwell]

Tests are passing on both github actions and circle ci. Happy to merge this one in.