Clarify difference with Crockford's base32
#57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kachick
changed the title
Crockford's base32
kachick
commented
May 1, 2021
| - Uses Crockford's base32 for better efficiency and readability (5 bits per character) | ||
| - Uses subset of Crockford's base32 for better efficiency and readability (5 bits per character) | ||
| - Major difference with `Crockford's base32` is not be able to contain `iIlLoO` and `hyphens(-)` | ||
| - All characters except `0123456789ABCDEFGHJKMNPQRSTVWXYZabcdefghjkmnpqrstvwxyz` are invalid in ULID |
There was a problem hiding this comment.
I know a suggestion exists to restrict only for uppercase #3
But this PR does not scope it 🙇
This was referenced May 3, 2021
kachick
added a commit
to kachick/ruby-ulid
that referenced
this pull request
May 7, 2021
Might be changed in #57 and ulid/spec#57 But this is enough for now
kachick
added a commit
to kachick/ruby-ulid
that referenced
this pull request
May 17, 2021
Resolves #150 This is a simple solution for following issues * #78 * #57 * #143 * ulid/spec#57 * ulid/spec#3
|
Closing in favor of ietf-wg-uuidrev/rfc4122bis@6fbd9f0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #38, ulid/javascript#85, kachick/ruby-ulid#57, oklog/ulid#69, #49
Crockford's base32
Especially when accept
iIlLoOmapping as originalCrockford's base32decoding spec,Lexicographically sortableis lost 🤔@alizain @tuupola How do you think this change?