Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miniprofiler for v13 #13841

Merged
merged 5 commits into from
Feb 16, 2023
Merged

Miniprofiler for v13 #13841

merged 5 commits into from
Feb 16, 2023

Conversation

bergmania
Copy link
Member

Description

  • Configured miniprofiler to show reports in /umbraco/profiler/results-index
  • Configured to ignore endpoints we cannot do anything about, like swagger and the miniprofiler ones.
  • Configured the profilers to have the url path as name

Known limitation

  • Currently we cannot protect the endpoint. A FIXME is added

Tests

  • Ensure debug is enabled in config
  • Verify results is shown in /umbraco/profiler/results-index
  • Go try out endpoints from management API or web requests and verify those are shown

image

  • Ensure debug is disabled in config

image

Copy link
Member

@Zeegaan Zeegaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tests good 🎉

@Zeegaan Zeegaan merged commit d7ef924 into v13/dev Feb 16, 2023
@Zeegaan Zeegaan deleted the v13/feature/miniprofiler branch February 16, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants