Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UsePagedSqlQuery setting to NucacheSettings #14806

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented Sep 14, 2023

Fixes #13525

Notes

  • Implements a UsePagedSqlQuery in NuCacheSettings, that can now be set to false, to instead use Fetch
  • Would love to use an IOptionsMonitor instead to track changes, but we cannot refactor this to be non-breaking (even with ActivatorUtilitiesConstructor), as the constructors will be ambiguous 😢

How to test

  • Set the UsePagedSqlQuery to false:
  "Umbraco": {
    "CMS": {
      "NuCache": {
        "UsePagedSqlQuery" : false      },
  • Assert that you can still create doc types & content, and it works as expected
  • Go to the settings -> Profiling dashboard
  • Assert that you can rebuild the memory cache.

You can even test the times by cherry picking this Profiling PR in: #13841
and testing with the setting both set to false & true

@Zeegaan Zeegaan changed the title imlement UsePagedSqlQuery Add UsePagedSqlQuery setting to NucacheSettings Sep 14, 2023
@bergmania
Copy link
Member

Looks good to me.. We will need to backport this to v8

@bergmania bergmania merged commit 8ccc2fa into v10/dev Sep 14, 2023
18 checks passed
@bergmania bergmania deleted the v10/feature/add-UsePagedSqlQuery-nucache-setting branch September 14, 2023 18:11
wtct pushed a commit to wtct/Umbraco-CMS that referenced this pull request Jul 29, 2024
…vestigation of umbraco#16803 - well tested on db with 300k+ nodes
Zeegaan pushed a commit that referenced this pull request Aug 2, 2024
…tion of #16803 - well tested on db with 300k+ nodes (#16837)

Co-authored-by: Wojciech Tengler <wtengler@umbracare.net>
Zeegaan pushed a commit that referenced this pull request Aug 2, 2024
…tion of #16803 - well tested on db with 300k+ nodes (#16837)

Co-authored-by: Wojciech Tengler <wtengler@umbracare.net>
(cherry picked from commit 688790e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants