Fixed a couple of occurrences where scopes was auto-completed while modified db state #14947
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v12/dev)
succeeded
Oct 10, 2023 in 45s
CodeScene PR Check
✅ Quality Gates: OK
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
Details
🚩 Negative Code Health Impact (highest to lowest):
- String Heavy Function Arguments LogViewerConfig.cs
✅ Positive Code Health Impact (highest to lowest):
- Overall Code Complexity MemberUserStoreTests.cs
Annotations
Check notice on line 1 in src/Umbraco.Core/Services/ContentService.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v12/dev)
ℹ Getting worse: Lines of Code in a Single File
The lines of code increases from 2248 to 2252, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check warning on line 1 in src/Umbraco.Infrastructure/Logging/Viewer/LogViewerConfig.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v12/dev)
❌ New issue: String Heavy Function Arguments
In this module, 41.7% of all arguments to its 7 functions are strings. The threshold for string arguments is 39.0%. The functions in this file have a high ratio of strings as arguments. Avoid adding more.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v12/dev)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 4.50 to 4.38, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Loading