Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-15712 #16760

Closed
wants to merge 1 commit into from
Closed

Conversation

KudAndrii
Copy link

Issue:
#15712

Description:
UserDefaultLockoutTimeInMinutes was wrongly used instead of MemberDefaultLockoutTimeInMinutes to configure lockout time.

Testing:
enter wrong password needed amount of times to be locked out, and you will be locked out on UserDefaultLockoutTimeInMinutes amount of minutes without this fix.

Copy link

github-actions bot commented Jul 8, 2024

Hi there @KudAndrii, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@KudAndrii KudAndrii changed the title MemberDefaultLockoutTimeInMinutes fix. issue-15712 Jul 8, 2024
@georgebid
Copy link
Contributor

Hey @KudAndrii thanks a lot for this PR, someone on the core collaborators team will review this soon 😄

@JasonElkin JasonElkin self-assigned this Jul 25, 2024
@JasonElkin JasonElkin changed the base branch from v13/dev to contrib July 25, 2024 11:02
@JasonElkin JasonElkin changed the base branch from contrib to v13/dev July 25, 2024 11:07
@JasonElkin
Copy link
Contributor

Hi @KudAndrii, thanks for contributing a fix for this. Also, hello👋, it's always great to welcome a new contributor!

Unfortunately, because this is targeting v13/dev I can't merge this the normal way, would it be possible for you to rebase/recreate your PR targeting the latest contrib branch then we can get this merged in and backported to v13.

Thanks,
Jason

@KudAndrii
Copy link
Author

JasonElkin
please, see the new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants